Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate lost commits after rebasing refactor branch #2296

Closed
miketaylr opened this issue Mar 26, 2018 · 5 comments
Closed

Investigate lost commits after rebasing refactor branch #2296

miketaylr opened this issue Mar 26, 2018 · 5 comments

Comments

@miketaylr
Copy link
Member

@zoepage said the current refactor branch (which is on staging) is missing commits, or had some bad rebase side effects.

Ola, can you point us to what is wrong, so we can document it here?

@miketaylr
Copy link
Member Author

miketaylr commented Mar 26, 2018

oklay, staging is broken. so please don't check :D I'll fix it up and send a PR so we can deploy on monday. :)
It contains merge conflicts

Current refactor doesn't contain any instances of <<<<, etc. so I think @zoepage is referring to something else, possibly the wrong commit was merged in during rebase.

edit: Just chatted with Ola, and she suspects there are a big number of commits that were skipped or are missing in the rebased refactor branch. She's working on a PR to fix that. 🎉

@miketaylr
Copy link
Member Author

Here's one instance where we have double content now:

https://github.com/webcompat/webcompat.com/blob/refactor/tests/unit/test_urls.py#L95

zoepage added a commit that referenced this issue Mar 27, 2018
miketaylr pushed a commit that referenced this issue Mar 27, 2018
Fixes #2296 - send patch for lost commits
@zoepage
Copy link
Member

zoepage commented Mar 27, 2018

@miketaylr we can close this, right?

@zoepage
Copy link
Member

zoepage commented Mar 27, 2018

merged #2297

@zoepage zoepage closed this as completed Mar 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants