Fixes #2296 - send patch for lost commits #2297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miketaylr
approved these changes
Mar 27, 2018
| @@ -253,19 +253,20 @@ issues.ImageUploadView = Backbone.View.extend({ | |||
| return; | |||
| } | |||
|
|
|||
| var inlineHelp = $("<span></span>", { | |||
| // what is wc-Form-helpInline??? | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
|
||
| // this can probably go as we do not have wc- styles anymore? |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
| @@ -69,7 +69,7 @@ <h1 class="headline-1">Report Site Issue</h1> | |||
| </div> | |||
| <div class="form-text form-element js-Form-group"> | |||
| {{ form.os(class_='form-field text-field') }} | |||
| <span class="form-input-validation check js-bug-form-os"></span> | |||
| <span class="form-input-validation check"></span> | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
| @@ -85,7 +85,7 @@ <h1 class="headline-1">Report Site Issue</h1> | |||
| {{ subradio.label(class_='form-label label-radio') }} | |||
| {% endfor %} | |||
| </div> | |||
| <div class="form-upload js-image-upload js-Form-group loader js-image-loader"> | |||
| <div class="form-upload js-image-upload js-Form-group"> | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
🎉 thanks! LMK, if you have questions! |
miketaylr
force-pushed
the
merge-fix-patch
branch
from
8a5ed8b to
6ace3b5
Compare
|
OK, i removed those form.html bits, and we should be good to merge once Travis is green. |
miketaylr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @miketaylr
not 100% sure, I got everything. But should cover the bigger chunks.