Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cache buster to all production minified assets. #368

Closed
miketaylr opened this issue Nov 11, 2014 · 4 comments
Closed

Add cache buster to all production minified assets. #368

miketaylr opened this issue Nov 11, 2014 · 4 comments
Assignees
@miketaylr
Labels
type: site-development

Comments

@miketaylr
Copy link
Member

No description provided.

@miketaylr miketaylr self-assigned this Nov 11, 2014
miketaylr pushed a commit that referenced this issue Nov 11, 2014
Issue #368 - Add bust_cache to all production minified assets.
1de649e
@karlcow
Copy link
Member

karlcow commented Nov 12, 2014

It sounds good. What the HTTP headers currently looks like in between two updates for these resources.

@miketaylr
Copy link
Member Author

As mentioned in my PR, I think this isn't actually needed. Closing.

@miketaylr miketaylr reopened this Mar 10, 2015
@miketaylr
Copy link
Member Author

I want to revisit this. Plan of attack being:

  1. Have all JS/CSS assets use the cache-busting to be consistent
  2. Modify the cache busting function to be based on a MD5 of the file content, rather than a timestamp so we don't require anyone to re-download something they don't need to.

@miketaylr
Copy link
Member Author

Part 3 (probably should be it's own issue): Revisit our nginx cache setup, cf. https://serversforhackers.com/nginx-caching/

miketaylr pushed a commit that referenced this issue Mar 10, 2015
Issue #368: Part 1, add bust_cache param to minified production JS
726e888
miketaylr pushed a commit that referenced this issue Mar 10, 2015
Issue #368 - Move bust_cache function into a Jinja template helper
dbcb91a
miketaylr pushed a commit that referenced this issue Mar 10, 2015
Issue #368 - Compute cache busting param based on md5 hash of file
2e0f2d9
miketaylr pushed a commit that referenced this issue Mar 10, 2015
Issue #368 - Remove (now) unused STARTUP variable
dd58b64
miketaylr pushed a commit that referenced this issue Jul 20, 2015
Merge branch 'master' into issues/564/1
133cffe 
* master: (46 commits)
  Fixes #509 - mention [ci skip] in docs.
  v1.6.2 changelog
  Issues #588 - list style
  Fix #583 Using the function for checking dependencies
  Checking dependencies
  Modules needed for checking dependencies
  Two cases to handle
  Adding message
  Issue #368 - Remove (now) unused STARTUP variable
  Issue #368 - Compute cache busting param based on md5 hash of file
  Issue #368 - Move bust_cache function into a Jinja template helper
  Issue #368: Part 1, add bust_cache param to minified production JS
  Issue #587 - Add a task to check npm dependencies and run by default
  v1.6.1
  Fixes #591 - Typo in form field. >_<
  Tag v1.6.0
  Issue #572 - Remove right float for GitHub issue warp hint
  Issue #432 - Add js-form-error and js-no-error classes and update tests.
  Issue #432 - Add wc-Form-required class to problem label
  Added wc-Form, wc-ReportForm
  ...
@MaxMood96 MaxMood96 mentioned this issue Jan 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miketaylr miketaylr

Labels
type: site-development
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@miketaylr @karlcow