Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"G takes you to github..." on mobile #572

Closed
calexity opened this issue Mar 2, 2015 · 7 comments
Closed

"G takes you to github..." on mobile #572

calexity opened this issue Mar 2, 2015 · 7 comments

Comments

@calexity
Copy link
Contributor

calexity commented Mar 2, 2015

On the All Issues page -

I think we should link this message to Github rather than confusing people.
Possibly should do the same on Desktop. Either type g or just click the link.

Thoughts @karlcow @miketaylr @magsout

@tagawa
Copy link
Member

tagawa commented Mar 2, 2015

Agree re. the link.

And I notice now we don't have a similar message on individual issue pages but I think we should.

@calexity
Copy link
Contributor Author

calexity commented Mar 2, 2015

Yes, second that. Thanks @tagawa

tagawa added a commit to tagawa/webcompat.com that referenced this issue Mar 2, 2015
@miketaylr
Copy link
Member

Yeah, that's pretty goofy. Thanks for catching that @calexity / @tagawa.

miketaylr pushed a commit that referenced this issue Mar 2, 2015
Added link to GitHub views (#572)
@miketaylr
Copy link
Member

Ah, forgot about this issue: #449 (comment)

Looks a little goofy. Should we just left align it and call it a day?

@tagawa
Copy link
Member

tagawa commented Mar 3, 2015

I'll defer to @calexity's design sense.

@calexity
Copy link
Contributor Author

calexity commented Mar 8, 2015

I thought I responded to this, and it looks closed, but I think left-align or center-align should be fine, if it's still an open question.

@miketaylr
Copy link
Member

You have have @calexity -- sorry if I missed that. I'll pick left or center and we can deploy the fix today.

tagawa added a commit that referenced this issue Mar 9, 2015
miketaylr pushed a commit that referenced this issue Jul 20, 2015
* master: (46 commits)
  Fixes #509 - mention [ci skip] in docs.
  v1.6.2 changelog
  Issues #588 - list style
  Fix #583 Using the function for checking dependencies
  Checking dependencies
  Modules needed for checking dependencies
  Two cases to handle
  Adding message
  Issue #368 - Remove (now) unused STARTUP variable
  Issue #368 - Compute cache busting param based on md5 hash of file
  Issue #368 - Move bust_cache function into a Jinja template helper
  Issue #368: Part 1, add bust_cache param to minified production JS
  Issue #587 - Add a task to check npm dependencies and run by default
  v1.6.1
  Fixes #591 - Typo in form field. >_<
  Tag v1.6.0
  Issue #572 - Remove right float for GitHub issue warp hint
  Issue #432 - Add js-form-error and js-no-error classes and update tests.
  Issue #432 - Add wc-Form-required class to problem label
  Added wc-Form, wc-ReportForm
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants