Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable issues "filter" dropdown #373

Closed
miketaylr opened this issue Nov 11, 2014 · 1 comment
Closed

Enable issues "filter" dropdown #373

miketaylr opened this issue Nov 11, 2014 · 1 comment
Milestone
Ship full issues ...

Comments

@miketaylr
Copy link
Member

See:

issue-list.js#L82-L86
issue-list.js#L91-L92
@miketaylr miketaylr added this to the Ship full issues page milestone Nov 11, 2014
@miketaylr miketaylr mentioned this issue Nov 14, 2014
Merged
@miketaylr
Copy link
Member Author

Woohoo, last issue before closing this milestone. Hopefully done by the end of the week.

miketaylr pushed a commit that referenced this issue Dec 10, 2014
Issue #373 - enable Filter dropdown for /issues
38f0867
miketaylr pushed a commit that referenced this issue Dec 10, 2014
Issue #373 - Track params and path state in the Issue model.
49e2e13 
This way there's wayyyy less string parsing.
miketaylr pushed a commit that referenced this issue Dec 10, 2014
Issue #373 - fetchAndRenderIssues now constructs the model url.
f6bbc7b 
With an option to pass it the entire thing, rather than composing
from model path and params properties. This is used when following
Link header URIs.
miketaylr pushed a commit that referenced this issue Dec 10, 2014
Issue #373 - Use new fetchAndRenderIssues machinery.
56fa2d8
miketaylr pushed a commit that referenced this issue Dec 10, 2014
Issue #373 - Simplify updateModelParams.
8d9b669 
Now that we just get the param state from the model, we can
update it and let fetchAndRenderIssues do the rest of the work.
miketaylr pushed a commit that referenced this issue Dec 10, 2014
Issue #373 - Remove unused jQuery.deparam dependency.
4088516
miketaylr pushed a commit that referenced this issue Dec 10, 2014
Issue #373 - Update issue list tests to account for enabled dropdown.
857e9f8
@miketaylr miketaylr mentioned this issue Dec 10, 2014
Closed
@MaxMood96 MaxMood96 mentioned this issue Jan 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Ship full issues page
Development

No branches or pull requests
1 participant
@miketaylr