Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify filter + search interaction #416

Closed
miketaylr opened this issue Nov 20, 2014 · 5 comments
Closed

Clarify filter + search interaction #416

miketaylr opened this issue Nov 20, 2014 · 5 comments

Comments

@miketaylr
Copy link
Member

If a filter button is selected (e.g., untriaged), and a user does a search:

Do we
A) restrict results to filter
B) clear the filter and do the search as normal

cc @calexity

@calexity
Copy link
Contributor

I would think B. If someone wants to do a search with the filter, they can
add the keyword along with their search.
On Thu, Nov 20, 2014 at 9:48 AM Mike Taylor notifications@github.com
wrote:

If a filter button is selected (e.g., untriaged), and a user does a search:

Do we
A) restrict results to filter
B) clear the filter and do the search as normal

cc @calexity https://github.com/calexity


Reply to this email directly or view it on GitHub
#416.

@miketaylr
Copy link
Member Author

That's sort of how I felt too. Thanks.

@miketaylr miketaylr added this to the Ship full issues page milestone Dec 3, 2014
@miketaylr
Copy link
Member Author

  • if filter active and user searches, remove filter is-active class from filter button
  • if active search and user clicks filter, emtpy search box

@miketaylr
Copy link
Member Author

Once #373 is merged in, I need to make sure this works as expected.

@miketaylr
Copy link
Member Author

OK, #373 is live. Will open another issue to track what's going on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants