Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to upload image from an issue comment #687

Closed
miketaylr opened this issue Aug 28, 2015 · 3 comments
Closed

Add ability to upload image from an issue comment #687

miketaylr opened this issue Aug 28, 2015 · 3 comments
Assignees
@miketaylr
Milestone
Image uploading

Comments

@miketaylr
Copy link
Member

With #24, we can upload images from new bug reports. We should be able to do so from image comments as well. Since we interact with comments at the JS/API level, this will require extending upload.py to work accodingly (which I think @hallvors will need for some of the tooling he will be working on anyways.
@miketaylr miketaylr added this to the Image uploading milestone Aug 28, 2015
@miketaylr miketaylr self-assigned this Aug 28, 2015
@miketaylr
Copy link
Member Author

I'll probably use FormData for this, so if the client doesn't support that I guess we just won't display the form. Support seems pretty decent: http://caniuse.com/#feat=xhr2

miketaylr pushed a commit that referenced this issue Aug 31, 2015
Issue #687. Abstract out comment creation into a get_comment_data met…
89ca4d8 
…hod.
miketaylr pushed a commit that referenced this issue Aug 31, 2015
Issue #687. Add image upload input if the client supports FormData
134dcde
miketaylr pushed a commit that referenced this issue Aug 31, 2015
Issue #687. Less self more _.bind().
7aced4f
@miketaylr miketaylr mentioned this issue Sep 1, 2015
Closed
miketaylr pushed a commit that referenced this issue Sep 1, 2015
Issue #687. Abstract out comment creation into a get_comment_data met…
23cbde9 
…hod.
miketaylr pushed a commit that referenced this issue Sep 1, 2015
Issue #687. Add image upload input if the client supports FormData
b3d0d87
miketaylr pushed a commit that referenced this issue Sep 1, 2015
Issue #687. Less self more _.bind().
b0c2821
miketaylr pushed a commit that referenced this issue Sep 1, 2015
Issue #687. Clientside validation for comment image uploading.
4ad0fc1
miketaylr pushed a commit that referenced this issue Sep 2, 2015
Issue #687. We only allow POST for this endpoint, so checking request…
eb90ab3 
….method is redundant.
miketaylr pushed a commit that referenced this issue Sep 2, 2015
Issue #687. POST FormData to server and add image embedding comment o…
825eec4 
…n success.
@miketaylr
Copy link
Member Author

OK, all the mechanics are in place. Just waiting on UX design stuff in #681 and we can improve on what I've done here.

@miketaylr
Copy link
Member Author

Maybe we should just land this as is, and then iterate on improvements. I think I need to add some Ajax spinner jazz before sending a PR. Will work on that now.

miketaylr pushed a commit that referenced this issue Sep 11, 2015
Issue #687. Abstract out comment creation into a get_comment_data met…
4d04cae 
…hod.
miketaylr pushed a commit that referenced this issue Sep 11, 2015
Issue #687. Add image upload input if the client supports FormData
0990ee4
miketaylr pushed a commit that referenced this issue Sep 11, 2015
Issue #687. Less self more _.bind().
6f3850b
miketaylr pushed a commit that referenced this issue Sep 11, 2015
Issue #687. Clientside validation for comment image uploading.
02cf7ba
miketaylr pushed a commit that referenced this issue Sep 11, 2015
Issue #687. We only allow POST for this endpoint, so checking request…
3f2ae6b 
….method is redundant.
miketaylr pushed a commit that referenced this issue Sep 11, 2015
Issue #687. POST FormData to server and add image embedding comment o…
33bbba1 
…n success.
miketaylr pushed a commit that referenced this issue Sep 11, 2015
Issue #687. Show loading image while waiting on upload.
237bc5b
miketaylr pushed a commit that referenced this issue Sep 11, 2015
Issue #687. Actually only show upload if FormData is supported.
ec78e1f
miketaylr pushed a commit that referenced this issue Sep 21, 2015
Issue #687. Remove unused method import.
e3e6f9d
miketaylr pushed a commit that referenced this issue Sep 21, 2015
Issue #687. Use .js- prefixed classes for ImageUploadView.
27c5d7b
miketaylr pushed a commit that referenced this issue Sep 21, 2015
Issue #687. Remove unnecessary JSON -> dict -> JSON dance. /o\
de4f1b8
miketaylr pushed a commit that referenced this issue Oct 1, 2015
Issue #687. Abstract out comment creation into a get_comment_data met…
babb5aa 
…hod.
miketaylr pushed a commit that referenced this issue Oct 1, 2015
Issue #687. Add image upload input if the client supports FormData
2f12a92
miketaylr pushed a commit that referenced this issue Oct 1, 2015
Issue #687. Less self more _.bind().
97eb097
miketaylr pushed a commit that referenced this issue Oct 1, 2015
Issue #687. Clientside validation for comment image uploading.
159d28a
miketaylr pushed a commit that referenced this issue Oct 1, 2015
Issue #687. We only allow POST for this endpoint, so checking request…
3026659 
….method is redundant.
miketaylr pushed a commit that referenced this issue Oct 1, 2015
Issue #687. POST FormData to server and add image embedding comment o…
d6a3fc8 
…n success.
miketaylr pushed a commit that referenced this issue Oct 1, 2015
Issue #687. Show loading image while waiting on upload.
72b7942
miketaylr pushed a commit that referenced this issue Oct 1, 2015
Issue #687. Actually only show upload if FormData is supported.
3c053bd
miketaylr pushed a commit that referenced this issue Oct 1, 2015
Issue #687. Use .js- prefixed classes for ImageUploadView.
126831b
miketaylr pushed a commit that referenced this issue Oct 1, 2015
Issue #687. Remove unnecessary JSON -> dict -> JSON dance. /o\
50163d1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miketaylr miketaylr

Labels
None yet
Projects
None yet
Milestone
Image uploading
Development

No branches or pull requests
1 participant
@miketaylr