Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to upload images to backend #24

Closed
miketaylr opened this issue Mar 25, 2014 · 25 comments
Closed

Add ability to upload images to backend #24

miketaylr opened this issue Mar 25, 2014 · 25 comments

Comments

@miketaylr
Copy link
Member

Screenshots are super helpful for bug reports. We should consider adding this ability to our form and hosting images ourselves (or via a 3rd party API like imgur).

@miketaylr miketaylr added this to the Post-launch milestone Mar 25, 2014
@karlcow
Copy link
Member

karlcow commented Mar 25, 2014

The chinese version of Firefox has a screenshot feature, because it is one way for people to share images on social network. It's too complicated for many users to save as an image, etc. So they take a screenshot that they can share. It's quite cool.

So looking from where it could come from I checked MDN. I wonder if other browsers have similar APIs.

@calexity calexity changed the title Attach a screenshot Attach a screenshot (drag and drop) Dec 3, 2014
@miketaylr miketaylr changed the title Attach a screenshot (drag and drop) Add ability to upload screenshot on backend Aug 3, 2015
@miketaylr miketaylr changed the title Add ability to upload screenshot on backend Add ability to upload images to backend Aug 3, 2015
@miketaylr
Copy link
Member Author

Sorry for all the noise here. Just organizing my thoughts. We have 2 related Milestones:

  1. Image uploading
  2. Add a screenshot feature

2 depends on 1.

@miketaylr
Copy link
Member Author

There will be 3 possible ways to upload an image:

  1. When reporting an image, there should be an input[type=file]
  2. When commenting on an image, there should be an input[type=file] (in addition to dragon drop, eventually) 🐉 🐲
  3. When reporting an image from one of our addons that supports some sort of a screenshot API

Here's how I see this working for us, roughly:

For issue creation:

  1. The file is uploaded and returns a URI pointer to the file
  2. That URI is embedded in the issue body using GitHub image markdown syntax: ![file name here](http://path/to/image/)
  3. (I think GitHub uploads all these to their own CDN)

For issue commenting:
Same thing, but included inside a comment rather than the issue body.

test

@miketaylr
Copy link
Member Author

Testing something

@miketaylr
Copy link
Member Author

  1. (I think GitHub uploads all these to their own CDN)

So, that's true for true uploads. If you just provide a link to an image, it uses a content proxy:

https://cloudup.com/iSnv2nObVWn

magsout added a commit that referenced this issue Aug 18, 2015
miketaylr pushed a commit that referenced this issue Aug 18, 2015
miketaylr pushed a commit that referenced this issue Aug 18, 2015
miketaylr pushed a commit that referenced this issue Aug 18, 2015
miketaylr pushed a commit that referenced this issue Aug 18, 2015
@miketaylr miketaylr self-assigned this Aug 18, 2015
miketaylr pushed a commit that referenced this issue Aug 19, 2015
miketaylr pushed a commit that referenced this issue Aug 20, 2015
miketaylr pushed a commit that referenced this issue Aug 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants