Fixes #1239. Remove QR code related code. #1242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tagawa
suggested changes
Dec 16, 2016
There was a problem hiding this comment.
Thanks @miketaylr. There's also the file static/js/vendor/qr.min.js, then I think that's everything.
miketaylr
force-pushed
the
issues/1239/1
branch
from
be21730 to
3ff8be8
Compare
|
Oops, great catch! Thanks for review, @tagawa. |
|
Happy to help, but a bit sad too, but still happy. |
|
😞 FWIW, I'd be happy for this to come back at some point in the future, even though I never used it. But since it's not working right now, seems good to reduce page load. |
miketaylr
added
status: in progress
status: add to changelog
and removed
status: in progress
labels
|
@tagawa @miketaylr my fault :( |
|
@magsout No, not at all! It's a good chance to get rid of clutter that's probably not being used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @tagawa -- in case I missed something obvious (but I think I got it all!).