Fixes #1262. Display new bug report URI, rather than /issues/new. #1272
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally I wanted to solve this on the Python side... but there's an issue:
Flask's
url_for
can only pass in variables if they're defined in the route as "variables". So for the following route we have the variable<int:number>
if we do
return redirect(url_for('show_issue', number=123, show_thanks_flash=False)
,we get redirected to
/issues/123?show_thanks_flash=False
(because stuff it doesn't recognize is treated as GET args).We could work around this by defining a route like so:
@app.route('/issues/<int:number>/<thanks>')
, but people might bookmark that.I wonder if we could work around this with the session cookie, rather than doing it in JS? Or some other idea?
Not ready for review. Let me try the session thingy.