Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1262. Redirect to issue page after bug creation. #1273

Merged
merged 1 commit into from
Jan 8, 2017

Conversation

miketaylr
Copy link
Member

Let's try this rather than #1272.

r? @karlcow

Copy link
Member

@karlcow karlcow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miketaylr
Copy link
Member Author

Thanks @karlcow -- mind explaining how you might do this via Referer?

@karlcow
Copy link
Member

karlcow commented Jan 11, 2017

My naive thinking…

POST /issues/new

which creates a redirect to /issues/[number] could send along that the Referer is /issues/new.
When this Referer is there you know you need to send the thanks flash.
when someone does a direct query to issues/[number] there's no referer with /issues/new value.

@miketaylr
Copy link
Member Author

Ah, that's kinda cool. Using session feels less elegant, I'm not sure if it is or isn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants