The BIG Refactor #2039

zoepage · 2018-01-25T20:35:28Z

Lets see how bad it really is...

miketaylr · 2018-03-16T22:58:45Z

Before we start the review process, let's be sure to rebase against master -- I think a few PRs have landed there.

…review. Now we show it on the containing <div>.

Fixes #2310 - remove XML declaration

Fixes #2312 - remove href from button

Fixes #2317 - remove gray border of sub-nav

Fixes #2319 - remove unused css class in js

Fixes #2324 - add js class to separate css and js functionality

Fixes #2204 - add license info of new icon set

Fixes #2216 - add screenshots

miketaylr · 2018-03-28T16:15:20Z

Need to investigate why tests are failing now.

miketaylr · 2018-03-28T16:20:13Z

I think something is wacky on travis, i'm going to nuke the build cache and restart.

Still failed, but tests are running and passing locally, so I'm not super concerned.
TOTAL: tested 2 platforms, 164 passed, 0 failed

zoepage · 2018-03-28T16:44:40Z

I had that issue too, but it disappeared after restarting the build

Fixes #2322 - rename `fix` to `lint:fix`in pkg.json

Fixes #2306 - remove unused CSS

Fixes #2329 - remove inline style

Issue #2334. Ensure that we consider browser-sent images as valid.

miketaylr · 2018-03-28T21:00:38Z

And tests decided to start passing again, yay!

miketaylr

🥁 ..... 🎉

zoepage requested review from miketaylr and removed request for miketaylr January 25, 2018 20:35

zoepage added the status: do not merge label Jan 25, 2018

zoepage removed the status: do not merge label Feb 15, 2018

zoepage and others added 25 commits March 23, 2018 10:54

Issue #2017 - fix watch task and postcss

2eeffe6

Issue #2012 - normalize dropdown

b4d9d1a

#2012 #2017 - fix svg + add search

766d261

Issue #2012 - fix z-index for dropdown

9a4c4ec

Issue #2012 - fix z-index for nav

510e8cb

Issue #2012 - fix pagination

d2ce836

Issue #2012 - remove double headline

920b671

Issue #2012 - fix search-bar z-index

00218ce

Issue #2012 - fix grid for new issue

681fb7d

FIX - broken css build

31d5888

Issue #2037 - moved min.css to dist folder

90654a8

Issue #1891. Remove redudant <label> and change where we show image p…

1c3b24b

…review. Now we show it on the containing <div>.

Issue #1891. Update image preview tests for new selector.

b04ce79

Issue #1891. Fix anonymous submit button type and name.

4856021

Issue #1891. New Issue route needs a js-ReportForm parent like homepage.

4b2dd40

Issue #1891. Get "remove image upload" working again.

5d6554f

Issue #1891. Add rudimentary styles for image upload error.

2a33f2f

Issue #1891 - remove unused wc- css styles

226042c

Issue #1891 - changed error msg class

ba73678

Issue #1891 - added validation to input fields

c79607d

Issue #1891 - fix height of upload label

a703358

Issue #1891 - add upload add / remove, layout fixes

76e4e24

Issue #1891 - layout fixes + new validation svgs

d257975

Issue #1891 - fix flash message for max upload size

49a5be1

Issues #1891 - revert temp fix for downsizing img

87fc5f4

zoepage and others added 13 commits March 28, 2018 14:01

Issue #2317 - remove gray border of sub-nav

67941bb

Issue #2319 - remove unused css class in js

a7dbbdd

Issue #2322 - change fix to lint:fix

d500d34

Issue #2324 - add js class to separate css and js functionality

43d1e29

Issue #2204 - add license info of new icon set

f3f571f

Issue #2216 - add screenshots

41f9e5f

Merge pull request #2311 from /issues/2310

527d039

Fixes #2310 - remove XML declaration

Merge pull request #2313 from /issues/2312

71be5d4

Fixes #2312 - remove href from button

Merge pull request #2318 from /issues/2317

b70083e

Fixes #2317 - remove gray border of sub-nav

Merge pull request #2321 from /issues/2319

aecafd2

Fixes #2319 - remove unused css class in js

Merge pull request #2325 from /issues/2324

101e20c

Fixes #2324 - add js class to separate css and js functionality

Merge pull request #2327 from /issues/2204

80aeee5

Fixes #2204 - add license info of new icon set

Merge pull request #2328 from /issues/2216-2

a93fec0

Fixes #2216 - add screenshots

zoepage and others added 7 commits March 28, 2018 20:29

Issue #2322 - update docs

e5a0a45

Merge pull request #2323 from /issues/2322

1f5652e

Fixes #2322 - rename `fix` to `lint:fix`in pkg.json

Merge pull request #2309 from /issues/2306

07b0f3a

Fixes #2306 - remove unused CSS

Issue #2329 - remove inline style

f80bec5

Merge pull request #2333 from /issues/2329

6a66f4e

Fixes #2329 - remove inline style

Issue #2334. Ensure that we consider browser-sent images as valid.

3b9f637

Merge pull request #2335 from /issues/2334/1

2711abe

Issue #2334. Ensure that we consider browser-sent images as valid.

miketaylr approved these changes Mar 28, 2018

View reviewed changes

miketaylr merged commit cb766b2 into master Mar 28, 2018

miketaylr added the status: add to changelog label Mar 28, 2018

zoepage deleted the refactor branch March 28, 2018 21:50

miketaylr removed status: add to changelog labels Mar 30, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

The BIG Refactor #2039

The BIG Refactor #2039

zoepage commented Jan 25, 2018

miketaylr commented Mar 16, 2018

miketaylr commented Mar 28, 2018

miketaylr commented Mar 28, 2018 •

edited

Loading

zoepage commented Mar 28, 2018

miketaylr commented Mar 28, 2018

miketaylr left a comment

The BIG Refactor #2039

The BIG Refactor #2039

Conversation

zoepage commented Jan 25, 2018

miketaylr commented Mar 16, 2018

miketaylr commented Mar 28, 2018

miketaylr commented Mar 28, 2018 • edited Loading

zoepage commented Mar 28, 2018

miketaylr commented Mar 28, 2018

miketaylr left a comment

Choose a reason for hiding this comment

miketaylr commented Mar 28, 2018 •

edited

Loading