Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #668: Add in status- prefix to "new" query params. #674

Merged
merged 2 commits into from
Aug 14, 2015

Conversation

miketaylr
Copy link
Member

Maybe the last bug related to label renaming? 😄

r? @karlcow

@miketaylr
Copy link
Member Author

× firefox 31.0 on LINUX - issues - Comment form not visible for logged out users
× firefox 31.0 on LINUX - issue-list - results are loaded from the query params 

I have no idea why these two tests started failing recently--they're unrelated to these changes (they also fail in my #24 branch).

@miketaylr
Copy link
Member Author

I wonder if it's somehow a Firefox 31 bug, even though we've specified Firefox 39. I filed travis-ci/travis-ci#4649 for that issue.

@miketaylr miketaylr force-pushed the issues/668/1 branch 2 times, most recently from 49908ab to 8acbeea Compare August 13, 2015 22:47
@miketaylr
Copy link
Member Author

OK, I got this down to 1 failure. Will keep poking at it.

@miketaylr
Copy link
Member Author

And I think the other failure is somehow related to an actual bug. Still looking.

@miketaylr
Copy link
Member Author

In the interest of getting us (closer) to passing again I'm going to merge this. The change itself is pretty trivial.

miketaylr pushed a commit that referenced this pull request Aug 14, 2015
Issue #668: Add in status- prefix to "new" query params.
@miketaylr miketaylr merged commit ad22ef9 into master Aug 14, 2015
@miketaylr miketaylr deleted the issues/668/1 branch August 14, 2015 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant