-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #687 - Add ability to upload images in comments for an issue #703
Conversation
….method is redundant.
(I still need to fix the flaky tests, the failures are unrelated). |
@@ -21,6 +21,7 @@ | |||
from webcompat import cache | |||
from webcompat import github | |||
from webcompat import limiter | |||
from webcompat.helpers import get_comment_data | |||
from webcompat.helpers import get_headers | |||
from webcompat.helpers import get_request_headers | |||
from webcompat.helpers import get_user_info |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
@miketaylr r+ for the python part. Tested. Code is working. I have a curiosity question up there, but that's just for curiosity. |
hum need help I think @miketaylr When I try to log in (localhost)
|
@magsout try to erase session.db first. Then restart |
@karlcow same error :( |
Bummer @magsout. Two debug requests:
|
@magsout you seem to have logged in ? |
@karlcow yes but no. I'm not logged
I'm logged on Github. I tried to logged out and logged in... |
Man, webapps are hard. @magsout, I don't recall if I shared the id and secret for the local testing app (that's what will correspond to the part from config.py below) with you or not. I just reset all user tokens there, but if you made your own can you try to "Revoke all users tokens"?
|
And after doing that, |
Heu no, I sent to you my config by email.
Done, and still same error :( |
@@ -95,6 +94,126 @@ issues.TextAreaView = Backbone.View.extend({ | |||
}, 250, {maxWait: 1500}) | |||
}); | |||
|
|||
issues.ImageUploadView = Backbone.View.extend({ | |||
tagName: 'div', | |||
className: 'wc-Form-group', |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Except my comment LGTM r+ |
You're awesome @karlcow. 🎈 That's just a mistake on my part, I forgot that |
Fixes #687 - Add ability to upload images in comments for an issue
r? @karlcow for Python bits
r? @magsout for CSS + JS