Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #855 - Layout broken on contributors page #888

Merged
merged 2 commits into from
Dec 30, 2015
Merged

Issue #855 - Layout broken on contributors page #888

merged 2 commits into from
Dec 30, 2015

Conversation

magsout
Copy link
Member

@magsout magsout commented Dec 29, 2015

Close #855

r? @miketaylr

@miketaylr
Copy link
Member

Seems like the tests that are failing are related to the contributors page:

FAIL: main - Contributors - clicking first section closes it (10563ms)

Maybe we need to add js-blah classes so we don't break them in the future. Will take a look in a bit.

@magsout
Copy link
Member Author

magsout commented Dec 29, 2015

let me fixe this

@miketaylr
Copy link
Member

💯

@magsout
Copy link
Member Author

magsout commented Dec 30, 2015

OK, fixed 👍

@miketaylr
Copy link
Member

Woohoo!

miketaylr pushed a commit that referenced this pull request Dec 30, 2015
Merge pull request #888 from webcompat/contributors-page
878036b 
Issue #855 - Layout broken on contributors page
@miketaylr miketaylr merged commit 878036b into master Dec 30, 2015
@miketaylr miketaylr deleted the contributors-page branch December 30, 2015 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@magsout @miketaylr