-
-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract check for unique operation types into separate rule #995
Conversation
Codecov Report
@@ Coverage Diff @@
## master #995 +/- ##
============================================
+ Coverage 94.47% 94.49% +0.02%
Complexity 50 50
============================================
Files 119 120 +1
Lines 9617 9635 +18
============================================
+ Hits 9086 9105 +19
+ Misses 531 530 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks solid overall, can be micro-optimized a bit
Can you add a CHANGELOG entry to mention the introduction of a new rule? |
@spawnia It's ready. |
Introduces
UniqueOperationTypes
validation rule.Corresponding change in the reference implementation: graphql/graphql-js@9b7a8af