Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dnm] chore: remove Node.js 4, add Node.js 10 #80

Merged
merged 3 commits into from
Jan 4, 2019
Merged

[dnm] chore: remove Node.js 4, add Node.js 10 #80

merged 3 commits into from
Jan 4, 2019

Conversation

DanielRuf
Copy link
Contributor

@DanielRuf DanielRuf commented May 3, 2018

Closes #79

@DanielRuf
Copy link
Contributor Author

See the following because of the failing Windows build: nodejs/node#20297

@evenstensberg
Copy link
Member

@evilebottnawi should we add v10 anyways?

@alexander-akait
Copy link
Member

Looks we catch node 10.0.0 bug 😆

@alexander-akait
Copy link
Member

@ev1stensberg yep, we need add 10.0.0 in all webpack/webpack-contrib repos

@alexander-akait
Copy link
Member

Blocker nodejs/node#20297. Using webpack and watch mode on nodejs 10.0.0 can't works as expected 😞

@alexander-akait alexander-akait changed the title chore: remove Node.js 4, add Node.js 10 [dnm] chore: remove Node.js 4, add Node.js 10 May 3, 2018
@DanielRuf
Copy link
Contributor Author

webpack and watch mode

The watch mode is used on CI? Shouldn't this not be the case normally?

@alexander-akait
Copy link
Member

@DanielRuf here tests for watch systems

@DanielRuf
Copy link
Contributor Author

@DanielRuf here tests for watch systems

Ah ok, makes definitely sense 😃 Sorry.

@alexander-akait
Copy link
Member

@DanielRuf we need restart CI, node 10.1.0 release

@codecov
Copy link

codecov bot commented May 10, 2018

Codecov Report

Merging #80 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #80   +/-   ##
======================================
  Coverage    95.5%   95.5%           
======================================
  Files           3       3           
  Lines         356     356           
  Branches       97      97           
======================================
  Hits          340     340           
  Misses         16      16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d839e8...0ca8fad. Read the comment docs.

@DanielRuf
Copy link
Contributor Author

@DanielRuf we need restart CI, node 10.1.0 release

Seems it is not yet available on Appveyor. Should I ping them?

@DanielRuf
Copy link
Contributor Author

See nodejs/node#20738

@alexander-akait
Copy link
Member

/cc @ooflorent can you restart CI, looks i don't have access

@ooflorent
Copy link
Member

I don’t have enough privilege on appveyor. Close/reopen works best.

@ooflorent ooflorent closed this Jun 8, 2018
@ooflorent ooflorent reopened this Jun 8, 2018
@ooflorent ooflorent closed this Jul 6, 2018
@ooflorent ooflorent reopened this Jul 6, 2018
@codecov
Copy link

codecov bot commented Sep 18, 2018

Codecov Report

Merging #80 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #80   +/-   ##
======================================
  Coverage    95.5%   95.5%           
======================================
  Files           3       3           
  Lines         356     356           
  Branches       97      97           
======================================
  Hits          340     340           
  Misses         16      16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d839e8...0ca8fad. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Sep 18, 2018

Codecov Report

Merging #80 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #80   +/-   ##
======================================
  Coverage    95.5%   95.5%           
======================================
  Files           3       3           
  Lines         356     356           
  Branches       97      97           
======================================
  Hits          340     340           
  Misses         16      16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d839e8...0ca8fad. Read the comment docs.

@sokra sokra merged commit b373c5f into webpack:master Jan 4, 2019
@sokra
Copy link
Member

sokra commented Jan 4, 2019

Thanks

@DanielRuf DanielRuf deleted the chore/remove-nodejs-4-add-nodejs-10 branch March 17, 2019 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants