Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove Node.js 4 (EOL) #81

Closed
wants to merge 1 commit into from
Closed

chore: remove Node.js 4 (EOL) #81

wants to merge 1 commit into from

Conversation

DanielRuf
Copy link
Contributor

Closes #79

@alexander-akait
Copy link
Member

@DanielRuf Duplicate #80?

@codecov
Copy link

codecov bot commented May 3, 2018

Codecov Report

Merging #81 into master will decrease coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #81      +/-   ##
==========================================
- Coverage    95.5%   95.22%   -0.29%     
==========================================
  Files           3        3              
  Lines         356      356              
  Branches       97       97              
==========================================
- Hits          340      339       -1     
- Misses         16       17       +1
Impacted Files Coverage Δ
lib/DirectoryWatcher.js 95% <0%> (-0.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d839e8...0dca30e. Read the comment docs.

@DanielRuf
Copy link
Contributor Author

@DanielRuf Duplicate #80?

Not directly. This PR is just for removing the EOL Node.js version. The other is for adding Node.js 10 and removing Node.js 4 (which I will problably close then or force-push with just the Node.js 10 addition) to keep the changes atomic.

@realityking
Copy link
Contributor

Partially duplicates #64. I suspect it hasn't been merged yet to avoid a semver-major release.

@DanielRuf
Copy link
Contributor Author

Hm, you are right. Oversaw this one. Should I close my PR then?

@realityking
Copy link
Contributor

I slightly prefer mine because it adds the engine to package.json but I'm not the PR police 😆

@DanielRuf DanielRuf closed this May 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants