Update to webpack 3 #946

lencioni · 2017-06-19T15:56:23Z

Now that webpack 3 is out, I am bumping some versions in here
so folks can update. I don't know if any other changes are required
but I figured I'd get the ball rolling.

Addresses #932

What kind of change does this PR introduce?

Updating dependencies

Did you add or update the examples/?
No

Summary

I'd like to help unblock people who are using webpack-dev-server so they can update to webpack 3.

Does this PR introduce a breaking change?

No

Other information
This may need additional work, but I figured I'd get the ball rolling.

jsf-clabot · 2017-06-19T15:56:24Z

All committers have signed the CLA.

codecov · 2017-06-19T16:05:01Z

Codecov Report

Merging #946 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #946   +/-   ##
=======================================
  Coverage   72.13%   72.13%           
=======================================
  Files           4        4           
  Lines         463      463           
  Branches      139      139           
=======================================
  Hits          334      334           
  Misses        129      129

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbcdca7...8978059. Read the comment docs.

snyamathi · 2017-06-20T21:20:38Z

@lencioni fyi - Your build is going to fail until webpack/webpack-dev-middleware#200 is released because of the devDependency bump to version 3 (which is the right thing to do).

npm ERR! Linux 4.8.12-040812-generic
npm ERR! argv "/home/travis/.nvm/versions/node/v4.8.3/bin/node" "/home/travis/.nvm/versions/node/v4.8.3/bin/npm" "install"
npm ERR! node v4.8.3
npm ERR! npm  v2.15.11
npm ERR! code EPEERINVALID
npm ERR! peerinvalid The package webpack@3.0.0 does not satisfy its siblings' peerDependencies requirements!
npm ERR! peerinvalid Peer webpack-dev-middleware@1.10.2 wants webpack@1 || ^2.1.0-beta || ^2.2.0-rc.0
npm ERR! Please include the following file with any support request:
npm ERR!     /home/travis/build/webpack/webpack-dev-server/npm-debug.log

lencioni · 2017-06-20T21:41:41Z

@snyamathi Yeah, I saw that as well. Thanks for noting it!

ankurk91 · 2017-06-21T06:34:40Z

@lencioni
can you rebase, your PR gets outdated

lencioni · 2017-06-21T18:36:48Z

Freshly rebased!

Now that webpack 3 is out, I am bumping some versions in here so folks can update. I don't know if any other changes are required but I figured I'd get the ball rolling.

lencioni · 2017-06-22T15:49:20Z

Looks like webpack-dev-middleware 1.11.0 is out now, so I've updated this PR to include that as well.

mcbain · 2017-06-23T11:27:23Z

+1

lencioni · 2017-06-23T16:07:20Z

@SpaceK33z @sokra please let me know if there is anything I can do to help move this along. Thanks!

deepu105 · 2017-06-24T12:31:41Z

@sokra @TheLarkInn @SpaceK33z guys this is preventing us from upgrading to webpack 3 in JHipster. Any idea when this will be moved?
cc @jdubois

TheLarkInn · 2017-06-24T13:44:08Z

Going to add some priority to this.

deepu105 · 2017-06-26T07:07:30Z

@TheLarkInn any idea when this might be released?

mareksuscak · 2017-06-27T12:33:53Z

A new version of webpack-dev-middleware has been out for like 5 days. Can we merge & release this change? What are we waiting for? Let me know if there's anything that needs to be done and I can certainly contribute some of my spare time.

michael-ciniawsky · 2017-06-27T16:27:33Z

@webpack/core-team @webpack/dev-server-team Yo 👋 :D, could someone give this priority please? Seems to be good to go ?

deepu105 · 2017-06-28T15:51:20Z

@webpack/core-team @webpack/dev-server-team Guys as an OSS project maintainer I know it's not fair to put pressure on people, but this issue literally makes it impossible to use webpack 3 in real projects, as you would always use webpack-dev-server along with it. So any progress would be extremely appreciated. If we can do anything to help please let us know we will help

MitchTalmadge · 2017-06-29T23:43:24Z

I agree with @deepu105, there is not a single webpack project I use that does not use webpack-dev-server. This makes the webpack v3 pretty much useless

TheLarkInn · 2017-06-30T01:44:48Z

Hey all I apologize for the delay. The usual maintainer has been out on his master's work. Let me pick this up real quick

TheLarkInn · 2017-06-30T01:46:57Z

Let me get this released as soon as I can

deepu105 · 2017-06-30T06:26:24Z

@TheLarkInn really appreciated now JHipster can finally ship with webpack 3 💃

jdubois · 2017-06-30T06:49:31Z

Can't wait to test the performance enhancements !
Thanks Microsoft :-)

Download · 2017-06-30T17:59:00Z

Is this on NPM? I am trying to install it with

npm install --save-dev webpack-dev-server

but keep getting:

webpack-dev-server@2.5.0 requires a peer of webpack@^2.2.0 but none was installed.

EDIT:

Latest release on NPM is 2.5.0:

sokra sokra published a week ago
2.5.0 is the latest of 100 releases

mareksuscak · 2017-06-30T18:28:45Z

@Download it's not. We also found several core plugins that haven't been updated yet (i.e. extract-text-webpack-plugin). Thus at my company we concluded it's not the right time to update to webpack 3 as of yet.

kuhnroyal · 2017-07-03T11:19:20Z

Need this released asap

Download · 2017-07-03T11:43:53Z

@TheLarkInn Any chance you could npm publish the version for 3?
Atm, when you npm install webpack webpack-dev-server you get incompatible versions.

TheLarkInn · 2017-07-07T05:56:27Z

So so so sorry about the delay on this all! I have now published as webpack-dev-server@2.5.1 🎉

deepu105 · 2017-07-07T06:42:01Z

Thanks Thanks & Regards, Deepu

…

On Fri, Jul 7, 2017 at 7:56 AM, Sean Larkin ***@***.***> wrote: So so so sorry about the delay on this all! I have now published as ***@***.*** 🎉 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#946 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABDlF_bB1j6lb6HMoYjsCsk411TuWzb9ks5sLciOgaJpZM4N-b3N> .

- add .npmrc, prevent package-lock.json - gitignore package-lock.json as an extraneous measure - update dependencies Examples: - add .npmrc, prevent package-lock.json - add README - move babel from package.json to .babelrc - eliminate unnecessary devdependencies: - babel-preset-stage-2 - postcss-cssnext - postcss-import - postcss-loader - update dependencies, devDependencies - eliminate unnecessary webpack configurations: - production logic to uglifyjs - postcss loaders - reference built CSS in example app (GridTestPage.jsx) Dependencies not updated to latest: - webpack stopped at 2.6.1 [pending webpack-dev-server support](webpack/webpack-dev-server#946) - eslint stopped at 3.19 [pending airbnb support](airbnb/javascript#1447)

avindra · 2017-07-07T21:40:26Z

Dawg. @TheLarkInn . You the man. If you're ever around in NYC I'll buy you coffee

cgatian · 2017-07-08T00:37:41Z

Actually it's kinda sad it took so long. I mean I know it's open source but still, there's a level of commitment some people hold this team to. Especially buying into the framework.

…

On Fri, Jul 7, 2017, 5:40 PM Avindra Goolcharan ***@***.***> wrote: Dawg. @TheLarkInn <https://github.com/thelarkinn> . You the man. If you're ever around in NYC I'll buy you coffee — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#946 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABq8ajaVTf8zWwRzgtHayGl6NaQPjkgIks5sLqXOgaJpZM4N-b3N> .

Andarist · 2017-07-08T07:07:12Z

You could have always just use a your own fork for a while with cherry-picked changes. Also upgrading to webpack3 is not you must do the first day it comes out. So really... please stop complaining about free stuff you get from the community.

cgatian · 2017-07-08T07:35:35Z

@Andarist I could always write my own. Right?

Andarist · 2017-07-08T07:39:53Z

Yeah. Thats also an option.

Download · 2017-07-08T13:25:24Z

Well complaining is not nice maybe. But he does have a point.

Also upgrading to webpack3 is not you must do the first day it comes out.

Maybe. But look at it from the other perspective: Releasing Webpack 3 before plugins have had a chance to update is also not something that has to be done right away. Maybe the Webpack team should have taken more time for testing? At least maybe a major release should be a more coordinated effort where all major webpack components push a new version nearly simultaneously?

I think that the Webpack team really dropped the ball on this release. Remember, as soon as you npm publish a major new version, from that moment on npm install webpack will start picking that new major version. For a project with the scope and reach of Webpack, that's a big deal. For two weeks it was impossible to do npm install webpack webpack-dev-server, which means anyone trying Webpack for the first time during that period will have had a difficult first experience.

Maybe peer dependencies needs to be looked at more closely? Is it really necessary to limit the upper bound? Can we maybe use open ended ranges? Or should there be a different procedure for release?

Some introspection is needed. Because what happened with v3 is not what the community expects from a package as big as Webpack.

No complaints. Especially not against any of the great people helping with Webpack. Thanks I use it almost every day! But just an observation that the way this went is not good.

jensen · 2017-07-09T22:59:32Z

Wow, the entitlement.

avindra · 2017-07-10T21:47:18Z

Peer dep mismatch are just warnings anyway right? At least it is with Yarn...

…

On Sun, Jul 9, 2017, 6:59 PM Karl Jensen ***@***.***> wrote: Wow, the entitlement. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#946 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAHvgO8E5FM4FeXmNg3LMB7y3yxozrNKks5sMVtWgaJpZM4N-b3N> .

deepu105 · 2017-07-11T06:10:34Z

Yes they are warnings and shouldn't cause any issues On 10 Jul 2017 11:47 pm, "Avindra Goolcharan" <notifications@github.com> wrote:

…

Peer dep mismatch are just warnings anyway right? At least it is with Yarn... On Sun, Jul 9, 2017, 6:59 PM Karl Jensen ***@***.***> wrote: > Wow, the entitlement. > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <#946# issuecomment-313971243>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/ AAHvgO8E5FM4FeXmNg3LMB7y3yxozrNKks5sMVtWgaJpZM4N-b3N> > . > — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#946 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABDlF1GQU6AYlfGvkpk_Y88s58mJvtwhks5sMpvqgaJpZM4N-b3N> .

michael-ciniawsky mentioned this pull request Jun 19, 2017

chore(package): update peerDependencies (webpack v3.0.0) #948

Closed

2 tasks

lencioni force-pushed the patch-1 branch from d0bf1fd to e816473 Compare June 21, 2017 18:36

This was referenced Jun 22, 2017

chore: allow webpack 3 #953

Closed

feat(@angular/cli): add scope hoisting via webpack 3 angular/angular-cli#6365

Merged

Update to webpack 3

8978059

Now that webpack 3 is out, I am bumping some versions in here so folks can update. I don't know if any other changes are required but I figured I'd get the ball rolling.

lencioni force-pushed the patch-1 branch from e816473 to 8978059 Compare June 22, 2017 15:48

lencioni mentioned this pull request Jun 23, 2017

ISSUE 947 - plugins defined with webpack 3 _modules Set in a develope… #956

Closed

sorin-davidoi mentioned this pull request Jun 23, 2017

Upgrade to Webpack 3 with module concatenation mastodon/mastodon#3912

Merged

LukeFarrawell mentioned this pull request Jun 23, 2017

Update webpack to 3.4.0 NUbots/NUsight2#55

Merged

5 tasks

deepu105 mentioned this pull request Jun 24, 2017

Upgrade to Webpack 3 jhipster/generator-jhipster#5955

Closed

TheLarkInn approved these changes Jun 24, 2017

View reviewed changes

screendriver mentioned this pull request Jun 26, 2017

Not compatible with webpack 3.0 ?? #961

Closed

snyamathi mentioned this pull request Jun 27, 2017

Make webpack-dev-server npm compatible with webpack@3.x.x #962

Closed

aericson mentioned this pull request Jun 28, 2017

Update to webpack v3 vintasoftware/django-react-boilerplate#110

Closed

joscha mentioned this pull request Jun 29, 2017

Using storybook with Webpack 3.0 breaks the hot module replacement. storybookjs/storybook#1371

Closed

SimenB mentioned this pull request Jun 29, 2017

Upgrade webpack Unleash/unleash-frontend#83

Closed

TheLarkInn merged commit 047a595 into webpack:master Jun 30, 2017

lencioni deleted the patch-1 branch June 30, 2017 14:37

Download mentioned this pull request Jul 5, 2017

npm ERR! peer dep missing: webpack@^2.2.0, required by webpack-dev-server@2.5.0 webpack/webpack#5218

Closed

webpack-bot mentioned this pull request Jul 6, 2017

npm ERR! peer dep missing: webpack@^2.2.0, required by webpack-dev-server@2.5.0 #976

Closed

ykzts mentioned this pull request Jul 7, 2017

Update webpack-dev-server to v2.5.1 mastodon/mastodon#4094

Merged

jpommerening mentioned this pull request Jul 7, 2017

Update template dependencies for webpack 3 (was: App template: Update to webpack 3) LaxarJS/generator-laxarjs2#17

Closed

Update to webpack 3 #946

Update to webpack 3 #946

Conversation

lencioni commented Jun 19, 2017

jsf-clabot commented Jun 19, 2017 • edited Loading

codecov bot commented Jun 19, 2017 • edited Loading

Codecov Report

snyamathi commented Jun 20, 2017

lencioni commented Jun 20, 2017

ankurk91 commented Jun 21, 2017

lencioni commented Jun 21, 2017

lencioni commented Jun 22, 2017

mcbain commented Jun 23, 2017

lencioni commented Jun 23, 2017

deepu105 commented Jun 24, 2017

TheLarkInn commented Jun 24, 2017

deepu105 commented Jun 26, 2017

mareksuscak commented Jun 27, 2017

michael-ciniawsky commented Jun 27, 2017

deepu105 commented Jun 28, 2017

MitchTalmadge commented Jun 29, 2017 • edited Loading

TheLarkInn commented Jun 30, 2017

TheLarkInn commented Jun 30, 2017

deepu105 commented Jun 30, 2017

jdubois commented Jun 30, 2017

Download commented Jun 30, 2017 • edited Loading

mareksuscak commented Jun 30, 2017

kuhnroyal commented Jul 3, 2017

Download commented Jul 3, 2017 • edited Loading

TheLarkInn commented Jul 7, 2017

deepu105 commented Jul 7, 2017 via email

avindra commented Jul 7, 2017

cgatian commented Jul 8, 2017 via email

Andarist commented Jul 8, 2017

cgatian commented Jul 8, 2017

Andarist commented Jul 8, 2017

Download commented Jul 8, 2017

jensen commented Jul 9, 2017

avindra commented Jul 10, 2017 via email

deepu105 commented Jul 11, 2017 via email

jsf-clabot commented Jun 19, 2017 •

edited

Loading

codecov bot commented Jun 19, 2017 •

edited

Loading

MitchTalmadge commented Jun 29, 2017 •

edited

Loading

Download commented Jun 30, 2017 •

edited

Loading

Download commented Jul 3, 2017 •

edited

Loading