Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Stylelint: "customSyntax" config is not recognised as dependency usage #799

Closed
6 tasks done
duncan-thacker opened this issue Oct 3, 2024 · 2 comments · Fixed by #802
Closed
6 tasks done
Labels
bug Something isn't working

Comments

@duncan-thacker
Copy link
Contributor

Prerequisites

Reproduction url

https://codesandbox.io/p/sandbox/zealous-northcutt-g94nf7

Reproduction access

  • I've made sure the reproduction is publicly accessible

Description of the issue

Including "customSyntax": "postcss-less" in the stylelint config does not mark postcss-less as a used dependency. knip definitely detects the config file correctly, but there is nothing in the plugin code that checks this field. https://github.com/webpro-nl/knip/blob/main/packages/knip/src/plugins/stylelint/index.ts

Knip produces the following report:

Unused devDependencies (1)
postcss-less  package.json

Workaround

By switching to a JS config, you can do

"customSyntax": require.resolve("postcss-less")

which causes the dependency to be correctly marked as used.

@duncan-thacker duncan-thacker added the bug Something isn't working label Oct 3, 2024
@duncan-thacker
Copy link
Contributor Author

I'll try to raise a PR for this at some point, for now it's just a nice-to-have so that knip works better out-of-the-box.

@webpro
Copy link
Collaborator

webpro commented Oct 3, 2024

Sounds great, thanks in advance! Let me know if you need anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants