Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stylelint plugin - fix issue where "customSyntax" property is not recognised as a resolved dependency #802

Merged

Conversation

duncan-thacker
Copy link
Contributor

Closes #799

Adds customSyntax to the stylelint plugin. Includes a test case.

@duncan-thacker
Copy link
Contributor Author

I can't run the tests locally as I'm on a windows machine. Pretty sure they'll pass though!

Copy link

pkg-pr-new bot commented Oct 4, 2024

Open in Stackblitz

bun add https://pkg.pr.new/knip@802

commit: 32acb88

@webpro
Copy link
Collaborator

webpro commented Oct 4, 2024

I can't run the tests locally as I'm on a windows machine. Pretty sure they'll pass though!

Thanks for the PR. Should run fine on Windows? Use bun run test for Bun or npm run test:node for Node.js. Same as in CI. Can I ask if there's an issue with either of those?

@webpro webpro merged commit fdb0246 into webpro-nl:main Oct 4, 2024
24 of 25 checks passed
@duncan-thacker
Copy link
Contributor Author

C:\Work\knip> bun run test
$ bun test test/*.test.ts test/**/*.test.ts
The command line is too long.
error: script "test" exited with code 1

All the tests fail when I do npm run test:node

@webpro
Copy link
Collaborator

webpro commented Oct 6, 2024

🚀 This pull request is included in v5.32.0. See Release 5.32.0 for release notes.

Using Knip in a commercial project? Please consider becoming a sponsor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Stylelint: "customSyntax" config is not recognised as dependency usage
2 participants