Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow org admins to set default workflow configs #2020

Merged
merged 38 commits into from
Aug 29, 2024
Merged

feat: Allow org admins to set default workflow configs #2020

merged 38 commits into from
Aug 29, 2024

Conversation

SuaYoo
Copy link
Member

@SuaYoo SuaYoo commented Aug 14, 2024 •
edited
Loading

Resolves #2017, follows #2031

Changes

  • Adds new org settings tab for updating crawl details
  • Refactors workflow-editor to move out utility functions
  • Updates user guide on org settings

Manual testing

  1. Log in as org admin
  2. Go to Settings -> Crawl Workflows
  3. Update settings and save
  4. Go to New Workflow
  5. Click through sections. Verify default values are set as expected
  6. Save new workflow. Verify values save as expected
  7. Go to Settings -> Crawl Workflows
  8. Remove settings and save
  9. Go to New Workflow. Verify default values are no longer set

@SuaYoo SuaYoo force-pushed the frontend-org-workflow-defaults branch 2 times, most recently from 4503deb to 332e7d2 Compare August 19, 2024 20:38
@SuaYoo SuaYoo force-pushed the frontend-org-workflow-defaults branch 2 times, most recently from 2736167 to 722164a Compare August 21, 2024 00:53
@SuaYoo SuaYoo marked this pull request as ready for review August 21, 2024 04:53
@SuaYoo SuaYoo mentioned this pull request Aug 21, 2024
Merged
@SuaYoo SuaYoo marked this pull request as draft August 21, 2024 21:18
@SuaYoo SuaYoo force-pushed the frontend-org-workflow-defaults branch 3 times, most recently from bab9226 to 447b63b Compare August 27, 2024 02:19
@SuaYoo SuaYoo marked this pull request as ready for review August 27, 2024 02:19
@SuaYoo SuaYoo force-pushed the frontend-org-workflow-defaults branch from 447b63b to 2895253 Compare August 27, 2024 20:02
@SuaYoo SuaYoo mentioned this pull request Aug 27, 2024
Merged
@SuaYoo
Copy link
Member Author

SuaYoo commented Aug 27, 2024

@Shrinks99 FYI moved docs changes over to #2050

@SuaYoo SuaYoo force-pushed the frontend-org-workflow-defaults branch from 2895253 to 12d7ec2 Compare August 28, 2024 17:25
@SuaYoo SuaYoo mentioned this pull request Aug 28, 2024
Merged
tw4l
tw4l reviewed Aug 29, 2024
View reviewed changes
frontend/src/strings/crawl-workflows/infoText.ts

type Field = keyof FormState;

const infoText: Partial<Record<Field, string | TemplateResult>> = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactoring!

tw4l
tw4l approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@tw4l tw4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work! Feature's working great in the frontend the reorganization of some of the workflow editor code and types is great.

@ikreymer
use 'Crawling Defaults' as the name of tab / component
22bacb2 
rename settings crawl-workflows -> crawling defaults
rename component to btrix-org-settings-crawling-defaults
@ikreymer
Copy link
Member

Renamed tab / component to 'Crawling Defaults' for consistency, to make it clear this is about defaults for crawl workflows and not to be confused with crawl workflows themselves.

Shrinks99
Shrinks99 approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@Shrinks99 Shrinks99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor docs fixes, other than this looks great!

@SuaYoo @Shrinks99
Apply suggestions from code review
f1a5027 
Co-authored-by: Henry Wilkinson <henry@wilkinson.graphics>
@SuaYoo SuaYoo merged commit 988d9c9 into main Aug 29, 2024
2 checks passed
@SuaYoo SuaYoo deleted the frontend-org-workflow-defaults branch August 29, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tw4l tw4l tw4l approved these changes

@ikreymer ikreymer ikreymer approved these changes

@Shrinks99 Shrinks99 Shrinks99 approved these changes

@emma-sg emma-sg Awaiting requested review from emma-sg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow org admins to set default workflow configs
4 participants
@SuaYoo @ikreymer @Shrinks99 @tw4l