Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a crawling defaults on the Org to allow setting certain crawl workflow fields as defaults: #2031

Merged
merged 3 commits into from
Aug 22, 2024
Merged

add a crawling defaults on the Org to allow setting certain crawl workflow fields as defaults: #2031

merged 3 commits into from
Aug 22, 2024

Conversation

ikreymer
Copy link
Member

@ikreymer
add a crawling defaults on the Org to allow setting certain crawl wor…
0cdb1bc 
…kflow fields as defaults:

- add POST /orgs/<id>/defaults/crawling API to update all defaults (defaults unset are cleared)
- defaults returned as 'crawlingDefaults' object on Org, if set
- fixes #2016
@ikreymer ikreymer requested a review from emma-sg August 20, 2024 20:07
emma-sg
emma-sg requested changes Aug 20, 2024
View reviewed changes
Copy link
Member

@emma-sg emma-sg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor thing, just a deprecation from pydantic

@ikreymer @emma-sg
Update backend/btrixcloud/orgs.py
0387641 
Co-authored-by: Emma Segal-Grossman <hi@emma.cafe>
@SuaYoo
Copy link
Member

SuaYoo commented Aug 20, 2024

It looks like we're missing maxCrawlSizeGB and crawlTimeout.

@ikreymer
Copy link
Member Author

It looks like we're missing maxCrawlSizeGB and crawlTimeout.

Added, replacing limit (page limit). Just maxCrawlSize to be consistent with how its stored in the workflow, but could do just GB if that's easier.

@SuaYoo SuaYoo mentioned this pull request Aug 21, 2024
Merged
@SuaYoo SuaYoo requested a review from emma-sg August 21, 2024 01:59
SuaYoo
SuaYoo approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@SuaYoo SuaYoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with #2020

@ikreymer ikreymer merged commit 04c8b50 into main Aug 22, 2024
5 checks passed
@ikreymer ikreymer deleted the add-org-crawling-defaults branch August 22, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuaYoo SuaYoo SuaYoo approved these changes

@emma-sg emma-sg emma-sg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API endpoint for workflow config defaults
3 participants
@ikreymer @SuaYoo @emma-sg