-
Notifications
You must be signed in to change notification settings - Fork 732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cross-browser builder support #1818
Comments
Tested on Safari 18 No longer an issue:
Still issues:
Unsure what this one means:
|
List of properties in tooltip is no longer scroll area, so not an issue |
Scrub now works in Safari except on spacing inputs. But if you open the spacing input it allows scrub. Canvas resizing also works. Though in both cases, as you are scrubbing/resizing, the cursor is highlighting what it's dragging over. That seems to be the main blocker but who knows... I'd need to spend some time building to see what other stuff pops up. Seems close though 🤷 safari.mp4 |
## Description ref #1818 There are no resize="auto" https://developer.mozilla.org/en-US/docs/Web/CSS/resize ## Steps for reproduction 1. click button 2. expect xyz ## Code Review - [ ] hi @kof, I need you to do - conceptual review (architecture, feature-correctness) - detailed review (read every line) - test it on preview ## Before requesting a review - [ ] made a self-review - [ ] added inline comments where things may be not obvious (the "why", not "what") ## Before merging - [ ] tested locally and on preview environment (preview dev login: 0000) - [ ] updated [test cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md) document - [ ] added tests - [ ] if any new env variables are added, added them to `.env` file
## Description Safari does not change the cursor based on `-webkit-user-select: none;` We need to explicitly set `cursor` ref #1818 ## Steps for reproduction 1. click button 2. expect xyz ## Code Review - [ ] hi @kof, I need you to do - conceptual review (architecture, feature-correctness) - detailed review (read every line) - test it on preview ## Before requesting a review - [ ] made a self-review - [ ] added inline comments where things may be not obvious (the "why", not "what") ## Before merging - [ ] tested locally and on preview environment (preview dev login: 0000) - [ ] updated [test cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md) document - [ ] added tests - [ ] if any new env variables are added, added them to `.env` file
A list of all bugs in each browser we currently don't support from builder
Safari
Esc when editing closes full screen in browser
Style source autocomplete has some extra text partially shown
(Related Advanced field jitter from specific declaration length #4616)
safari-clickout.mp4
Fixed or no longer an issue
Drag handle not showing on html embed windowfix: Resize drag handle in FF and Safari #4726When hovering over a paragraph instance, the select cursor is shownfeat: Make canvas cursor style compatible across all browsers #4727Copy by clicking on the navigator doesn’t work, must click on canvasWhen editing paragraph and clicking out, the edit cursor still shows when hovering over the PBg attachment buttons overflow wrapper (same with anything that uses that component)When style source is focused, then you switch instances, style source stays focused though backspace impacts the selected instance, not tokensspace and inputs scrub does not workcanvas resize does not workcss preview is not scrollabletooltip list of properties is not scrollablespace scrub doesn't work unless you expand inputsscrubbing and canvas resizing selects everything in its path as you dragImportant to note these were tested on Safari 18+. For example, on 17.1 scrub doesn't work
Firefox
Chromium 118
The text was updated successfully, but these errors were encountered: