Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-browser builder support #1818

Open
TrySound opened this issue Jun 18, 2023 · 4 comments
Open

Cross-browser builder support #1818

TrySound opened this issue Jun 18, 2023 · 4 comments
Labels
complexity:high Multiple weeks of work or more prio:2 Always look for prio:1 issues first before working on prio:2 type:bug Something isn't working

Comments

@TrySound
Copy link
Member

TrySound commented Jun 18, 2023

A list of all bugs in each browser we currently don't support from builder

Safari

  • Esc when editing closes full screen in browser

  • Style source autocomplete has some extra text partially shown

Screenshot 2025-01-06 at 8 48 54 AM Screenshot 2025-01-06 at 9 59 59 AM
  • Edit instance label, while focused try to click another instance but click blurs and doesn't select next instance. Vid shows Safari then Chrome
safari-clickout.mp4

Fixed or no longer an issue

  • Drag handle not showing on html embed window fix: Resize drag handle in FF and Safari #4726
  • When hovering over a paragraph instance, the select cursor is shown feat: Make canvas cursor style compatible across all browsers #4727
  • Copy by clicking on the navigator doesn’t work, must click on canvas
  • When editing paragraph and clicking out, the edit cursor still shows when hovering over the P
  • Bg attachment buttons overflow wrapper (same with anything that uses that component)
  • When style source is focused, then you switch instances, style source stays focused though backspace impacts the selected instance, not tokens
  • space and inputs scrub does not work
  • canvas resize does not work
  • css preview is not scrollable
  • tooltip list of properties is not scrollable
  • space scrub doesn't work unless you expand inputs
  • scrubbing and canvas resizing selects everything in its path as you drag

Important to note these were tested on Safari 18+. For example, on 17.1 scrub doesn't work

Firefox

  • zoom detection in breakpoints selector

Chromium 118

@TrySound TrySound added the type:bug Something isn't working label Jun 18, 2023
@kof kof added the prio:2 Always look for prio:1 issues first before working on prio:2 label Feb 10, 2024
@kof kof changed the title Safari bugs Cross-browser builder support blockers Apr 8, 2024
@kof kof added the complexity:high Multiple weeks of work or more label Apr 8, 2024
@kof kof changed the title Cross-browser builder support blockers Cross-browser builder support Apr 8, 2024
@johnsicili
Copy link
Contributor

Tested on Safari 18

No longer an issue:

  • css preview is not scrollable

Still issues:

  • canvas resize does not work
  • space and inputs scrub does not work

Unsure what this one means:

  • tooltip list of properties is not scrollable

@TrySound
Copy link
Member Author

List of properties in tooltip is no longer scroll area, so not an issue

@johnsicili
Copy link
Contributor

Scrub now works in Safari except on spacing inputs. But if you open the spacing input it allows scrub.

Canvas resizing also works.

Though in both cases, as you are scrubbing/resizing, the cursor is highlighting what it's dragging over. That seems to be the main blocker but who knows... I'd need to spend some time building to see what other stuff pops up. Seems close though 🤷

safari.mp4

istarkov added a commit that referenced this issue Jan 6, 2025
## Description

ref #1818

There are no resize="auto" 
https://developer.mozilla.org/en-US/docs/Web/CSS/resize

## Steps for reproduction

1. click button
2. expect xyz

## Code Review

- [ ] hi @kof, I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
0000)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env` file
istarkov added a commit that referenced this issue Jan 7, 2025
## Description

Safari does not change the cursor based on 
`-webkit-user-select: none;`

We need to explicitly set `cursor`

ref #1818

## Steps for reproduction

1. click button
2. expect xyz

## Code Review

- [ ] hi @kof, I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
0000)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env` file
@istarkov
Copy link
Member

istarkov commented Jan 7, 2025

image Can't reproduce `Style source autocomplete has some extra text partially shown`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity:high Multiple weeks of work or more prio:2 Always look for prio:1 issues first before working on prio:2 type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants