Upgrade to remix 1.7.6 #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/remix-run/remix/releases/tag/remix%401.7.0 https://github.com/remix-run/remix/releases/tag/remix%401.7.4 du -ckd1 node_modules -795648 +798524 Not much changes though I found since [1.7.5](https://github.com/remix-run/remix/releases/tag/remix%401.7.5) build started to hang when run with turbo or recursive pnpm run. Looks like in this commit some stream or connection not closed when build is finished. remix-run/remix#4410 Let's see if not fixed in newer versions and then file an issue.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Getting following errors in dev |
|
Did you mean the errors are coming with this update? That would mean we can't merge this ,right? |
|
Maybe this was there and remix just started to show it. Do you know where these attributes may come from? |
|
data-lt-installed doesn't exist anywhere, it is probably caused by Grammarly extension, try incognito mode |
kof
approved these changes
Jan 3, 2023
|
I haven't tested, approving in assumption that you did :) |
|
Great, catch. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/remix-run/remix/releases/tag/remix%401.7.0 https://github.com/remix-run/remix/releases/tag/remix%401.7.4
du -ckd1 node_modules
-795648
+798524
Not much changes though I found since 1.7.5 build started to hang when run with turbo or recursive pnpm run.
Looks like in this commit some stream or connection not closed when build is finished.
remix-run/remix#4410
Let's see if not fixed in newer versions and then file an issue.
Code Review
Before requesting a review
Before merging
.env.exampleand thedesigner/env-check.jsif mandatory