Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump remix to 1.9.0 #740

Merged
merged 1 commit into from
Jan 5, 2023
Merged

Bump remix to 1.9.0 #740

merged 1 commit into from
Jan 5, 2023

Conversation

TrySound
Copy link
Member

@TrySound TrySound commented Jan 5, 2023

Build issue still not fixed (#725)

Code Review

  • hi @kof, I need you to do
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env.example and the designer/env-check.js if mandatory

@TrySound TrySound requested a review from kof January 5, 2023 10:30
@vercel
Copy link

vercel bot commented Jan 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
webstudio-designer ✅ Ready (Inspect) Visit Preview Jan 5, 2023 at 10:33AM (UTC)

Copy link
Member

@kof kof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did basic testing

@TrySound TrySound merged commit f2a851c into main Jan 5, 2023
@TrySound TrySound deleted the remix-1.9.0 branch January 5, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants