Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to play MPEG-4 Audio Book (.m4b) #1452

Closed
4 tasks done
Borewit opened this issue Aug 15, 2018 · 2 comments
Closed
4 tasks done

Ability to play MPEG-4 Audio Book (.m4b) #1452

Borewit opened this issue Aug 15, 2018 · 2 comments
Assignees
@Borewit
Labels
enhancement

Comments

@Borewit
Copy link
Member

Borewit commented Aug 15, 2018 •
edited
Loading

Test data: one of the MPEG-4 Audio Book (.m4b) files part of : https://archive.org/details/glories_of_ireland_1801_librivox

Related:

  1. Reuse media extensions #1450: adding the .m4b extension, which I thought I had done before...
  2. Failed to parse MPEG-4 Audio Book File (m4b) Borewit/music-metadata#127 which is marked as bug, but it is in fact a workaround for an ugly tag appearing in these m4b file.

Issue is fixed if:
@Borewit Borewit self-assigned this Aug 15, 2018
This was referenced Aug 15, 2018
Merged
Merged
@Borewit
Copy link
Member Author

Borewit commented Aug 16, 2018

Test result:

fix-m4b

mathiasvr pushed a commit that referenced this issue Sep 26, 2018
@Borewit @mathiasvr
Asynchronous music-metadata updates while streaming (#1449)
06566d3 
* Ensure that default file/protocol handlers are re-installed after updating.

Previously, they were only installed when the preference was changed.
This caused the handlers to point to non-existing files after updates
occurred and older versions were removed by Squirrel.

Closes #791, #911.

* #1340: Switch to async metadata updates.

* Use fat arrow

* Fix issue track number not displayed if total number of tracks is not defined (common.track.of === null).

* Add disk number in addition to track number.

* Update order of audio properties from: album, track, disk, format to track, disk, album, format

* #1340 Update music-metadata to 2.5.0, enabling async 'per' tag updates
#1452 Fix for playing some '.m4b' files

* #1340 Commented out the metadata event debug output.

* #1340 Remove line comment to get rid of max line length lint error

* Update music-metadata 2.6.0 to fix some async events are getting triggered.

* Return JSX block.

* Get rid of third parameter which is replaced by CSS capitalize

* Fixed error when value is undefined.

* Update music-metadata dependency to 2.6.1.

* fix(package): update music-metadata to version 3.1.0

Closes #1478

* Revert "Ensure that default file/protocol handlers are re-installed after updating."

This reverts commit 39145b2.
@Borewit
Copy link
Member Author

Borewit commented Sep 27, 2018

Completed with PR #1449 merged.

@Borewit Borewit closed this as completed Sep 27, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Dec 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Borewit Borewit

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Borewit