Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

torrent handler registration broken? (windows) #791

Closed
anonymlol opened this issue Aug 20, 2016 · 6 comments · Fixed by #997
Closed

torrent handler registration broken? (windows) #791

anonymlol opened this issue Aug 20, 2016 · 6 comments · Fixed by #997
Labels
bug
Milestone
0.17

Comments

@anonymlol
Copy link
Contributor

anonymlol commented Aug 20, 2016 •
edited
Loading

What version of WebTorrent Desktop? (See the 'About WebTorrent' menu)
v 0.11.0 (0.96.1)

What operating system and version?
Windows 10 Pro x64

What did you do?
Click on magnet link (tried with and without using the toggle)

What did you expect to happen?
Expected the browser to ask to open with webtorrent-desktop (at least show it as an option)

What actually happened?
Webtorrent-desktop wasn't in the "open with" app list (for both magnet and stream-magnet). Torrent files (.torrent) weren't registered properly either (still defaulted to my other torrent client).
@feross
Copy link
Member

feross commented Aug 21, 2016

Was this a fresh install of WebTorrent Desktop? Or did you upgrade from a previous version?

We made a change in v0.11.0 to stop registering the app as the default handler until the user selects that option in the Preferences. Can you try that and see if it works for you?

@anonymlol
Copy link
Contributor Author

I had an older version and ran the installer to install v0.11.0. I tried the option in the preferences (the toggle I mentioned), it doesn't work.

@feross feross modified the milestones: v0.12, v0.13 Aug 21, 2016
@bnjmnt4n
Copy link
Member

I’m able to confirm this on Windows 10. Not too sure what’s wrong with the code though, will look through it.

@henrypijames
Copy link

henrypijames commented Sep 1, 2016 •
edited
Loading

Also confirm for WTD 0.12.0 (0.96.3) fresh install (non-portable) on Windows 10 x64.

Nothing happens (the preference button switches on and off, but no change in the Windows Registry either way), not even when running WTD as an administrator.

@anonymlol anonymlol mentioned this issue Sep 8, 2016
Closed
@dcposch dcposch modified the milestones: v0.14, v0.13 Sep 9, 2016
@dcposch dcposch modified the milestones: v0.16, v0.14 Sep 16, 2016
@anonymlol
Copy link
Contributor Author

Seems to be fixed with v.0.15, same as #911.

bnjmnt4n added a commit that referenced this issue Oct 2, 2016
@bnjmnt4n
Ensure that default file/protocol handlers are re-installed after upd…
5dc18f9 
…ating.

Previously, they were only installed when the preference was changed.
This caused the handlers to point to non-existing files after updates
occurred and older versions were removed by Squirrel.

Closes #791, #911.
@bnjmnt4n bnjmnt4n mentioned this issue Oct 2, 2016
Merged
bnjmnt4n added a commit that referenced this issue Oct 3, 2016
@bnjmnt4n
Ensure that default file/protocol handlers are re-installed after upd…
0c83259 
…ating.

Previously, they were only installed when the preference was changed.
This caused the handlers to point to non-existing files after updates
occurred and older versions were removed by Squirrel.

Closes #791, #911.
@feross
Copy link
Member

feross commented Oct 5, 2016

Duplicate of #911

@feross feross closed this as completed Oct 5, 2016
bnjmnt4n added a commit that referenced this issue Oct 6, 2016
@bnjmnt4n
Ensure that default file/protocol handlers are re-installed after upd…
39145b2 
…ating.

Previously, they were only installed when the preference was changed.
This caused the handlers to point to non-existing files after updates
occurred and older versions were removed by Squirrel.

Closes #791, #911.
@lock lock bot locked as resolved and limited conversation to collaborators May 10, 2018
mathiasvr pushed a commit that referenced this issue Sep 26, 2018
@Borewit @mathiasvr
Asynchronous music-metadata updates while streaming (#1449)
06566d3 
* Ensure that default file/protocol handlers are re-installed after updating.

Previously, they were only installed when the preference was changed.
This caused the handlers to point to non-existing files after updates
occurred and older versions were removed by Squirrel.

Closes #791, #911.

* #1340: Switch to async metadata updates.

* Use fat arrow

* Fix issue track number not displayed if total number of tracks is not defined (common.track.of === null).

* Add disk number in addition to track number.

* Update order of audio properties from: album, track, disk, format to track, disk, album, format

* #1340 Update music-metadata to 2.5.0, enabling async 'per' tag updates
#1452 Fix for playing some '.m4b' files

* #1340 Commented out the metadata event debug output.

* #1340 Remove line comment to get rid of max line length lint error

* Update music-metadata 2.6.0 to fix some async events are getting triggered.

* Return JSX block.

* Get rid of third parameter which is replaced by CSS capitalize

* Fixed error when value is undefined.

* Update music-metadata dependency to 2.6.1.

* fix(package): update music-metadata to version 3.1.0

Closes #1478

* Revert "Ensure that default file/protocol handlers are re-installed after updating."

This reverts commit 39145b2.
DiegoRBaquero pushed a commit that referenced this issue Sep 23, 2021
@bnjmnt4n
Ensure that default file/protocol handlers are re-installed after upd…
0d512db 
…ating. (#997)

Previously, they were only installed when the preference was changed.
This caused the handlers to point to non-existing files after updates
occurred and older versions were removed by Squirrel.

Closes #791, #911.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
0.17
5 participants
@feross @henrypijames @dcposch @bnjmnt4n @anonymlol