Update to WebUI v2.1.0 #7
Conversation
#New Features * Supporting more web browsers * Search for web browsers in Windows Reg. * Using the same show() function for HTML script, files, and refresh content * Support Chrome on macOS * The `getInt()` and `returnInt()` are now 64bit integer instead of 32bit #Breaking code * Switching from `show(html, browser);` to `show(content);`, and it's used for HTML, files, or reload the window * Removing `showCopy()`, `refresh()`, `refreshCopy()`
|
Sorry, the commit has the wrong title, |
webui/bindings.nim
Outdated
| @@ -249,10 +249,10 @@ proc scriptCleanup*(script: ptr Script) {.cdecl, | |||
| importc: "webui_script_cleanup", webui.} | |||
| proc scriptRuntime*(win: ptr Window; runtime: cuint) {.cdecl, | |||
| importc: "webui_script_runtime", webui.} | |||
| proc getInt*(e: ptr Event): cint {.cdecl, importc: "webui_get_int", webui.} | |||
| proc getInt*(e: ptr Event): int64 {.cdecl, importc: "webui_get_int", webui.} | |||
There was a problem hiding this comment.
You should use clonglong instead.
There was a problem hiding this comment.
Use clonglong for returnInt aswell.
There was a problem hiding this comment.
True, clonglong is better when interacting with a C/C++ library.
|
LGTM. |
|
Some of the core functions such as |
|
I just wanted to let you know that you don't need to. The function
|
|
The browser's order is like this now. |
|
Usually, all function that starts with |
|
I know that, but I would still like them to be available, however. |
Of course, that will be great. Something like showBrowser("<html>Hello World</html>", BrowserChrome);
showBrowser("index.html", BrowserFirefox); |
|
This PR LGTM. |
#New Features
getInt()andreturnInt()are now 64bit integer instead of 32bit#Breaking code
show(html, browser);toshow(content);, and it's used for HTML, files, or reload the windowshowCopy(),refresh(),refreshCopy()