Mac Build #9
Merged
Mac Build #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also tested on a x86_64 mac. Same issue with blank window/no wait, but it's building ok there, too. |
|
I tried forking @hassandraga's branch and making the small changes, and it built, but still had the same issue, so there may be more to it. |
|
Thank you for this! I don't have a mac so I haven't been able to test webui on macos. |
|
Looking at upstream C lib, it has same problem with Macs (wait seems to be returning immediately) so I am going to try to fix things there, too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #8 and #7
This doesn't totally fix it, but it gets it to build.
macosxnotmacospassCcomes before thecompile. Not sure if this is needed, but should be slightly more "correct"After this, it will build without error, but it still pops up a blank window, which might be related to API changes (see #7)
So, I think we can merge that PR and add these minor changes (maybe only switch to
macosx) and it should work better, everywhere.