Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): combine chmod with ADD in Dockerfile #313

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

sergeyberezansky
Copy link
Collaborator

@sergeyberezansky sergeyberezansky commented Sep 2, 2024

TL;DR

Optimized Dockerfile for Weka CSI Driver

What changed?

  • Updated the FROM statement syntax for the go-builder stage
  • Simplified the locar binary addition using a single ADD command with chmod
  • Removed separate RUN chmod command for locar

How to test?

  1. Build the Docker image using the updated Dockerfile
  2. Verify that the image builds successfully without errors
  3. Run a container from the built image and ensure all components, especially the locar binary, are present and executable

Why make this change?

  • Improves Dockerfile readability and maintainability
  • Reduces the number of layers in the final image by combining commands
  • Ensures consistent permissions for the locar binary using a single ADD command

chore(deps): combine chmod with ADD in Dockerfile

chore(deps): fix Dockerfile warning for FROM as

@sergeyberezansky sergeyberezansky added the ci Changes to CI/CD and release workflows label Sep 2, 2024
Copy link

graphite-app bot commented Sep 2, 2024

Graphite Automations

"Request reviewers once CI passes" took an action on this PR • (09/02/24)

1 reviewer was added to this PR based on Sergey Berezansky's automation.

@sergeyberezansky sergeyberezansky force-pushed the sergey/move-to-trash-error-prop branch from ed86ee8 to bc19431 Compare September 3, 2024 08:45
@sergeyberezansky sergeyberezansky force-pushed the sergey/docker-improvements branch from 4e1cb2d to e48646f Compare September 3, 2024 08:45
@sergeyberezansky sergeyberezansky force-pushed the sergey/move-to-trash-error-prop branch from bc19431 to d119ba2 Compare September 11, 2024 10:11
@sergeyberezansky sergeyberezansky force-pushed the sergey/docker-improvements branch from e48646f to b3c8c3c Compare September 11, 2024 10:11
@sergeyberezansky sergeyberezansky force-pushed the sergey/move-to-trash-error-prop branch from d119ba2 to eb55e84 Compare September 11, 2024 11:11
@sergeyberezansky sergeyberezansky force-pushed the sergey/docker-improvements branch from b3c8c3c to 1c3c1d0 Compare September 11, 2024 11:11
@sergeyberezansky sergeyberezansky force-pushed the sergey/move-to-trash-error-prop branch from eb55e84 to 1c8e239 Compare September 11, 2024 11:34
@sergeyberezansky sergeyberezansky force-pushed the sergey/docker-improvements branch from 1c3c1d0 to 49081ec Compare September 11, 2024 11:34
@sergeyberezansky sergeyberezansky force-pushed the sergey/move-to-trash-error-prop branch from 1c8e239 to eeb45e2 Compare September 11, 2024 11:51
@sergeyberezansky sergeyberezansky force-pushed the sergey/docker-improvements branch from 49081ec to d54acf8 Compare September 11, 2024 11:51
@sergeyberezansky sergeyberezansky force-pushed the sergey/move-to-trash-error-prop branch from eeb45e2 to 2d3878e Compare September 11, 2024 13:02
@sergeyberezansky sergeyberezansky force-pushed the sergey/docker-improvements branch from d54acf8 to 9a81bae Compare September 11, 2024 13:02
Copy link
Collaborator Author

sergeyberezansky commented Sep 12, 2024

Merge activity

  • Sep 12, 6:10 AM EDT: @sergeyberezansky started a stack merge that includes this pull request via Graphite.
  • Sep 12, 7:25 AM EDT: Graphite rebased this pull request as part of a merge.
  • Sep 12, 7:27 AM EDT: Graphite rebased this pull request as part of a merge.
  • Sep 12, 7:32 AM EDT: @sergeyberezansky merged this pull request with Graphite.

@sergeyberezansky sergeyberezansky changed the base branch from sergey/move-to-trash-error-prop to graphite-base/313 September 12, 2024 11:15
@sergeyberezansky sergeyberezansky changed the base branch from graphite-base/313 to dev September 12, 2024 11:23
@sergeyberezansky sergeyberezansky force-pushed the sergey/docker-improvements branch from f764c77 to bafd789 Compare September 12, 2024 11:24
@sergeyberezansky sergeyberezansky force-pushed the sergey/docker-improvements branch from bafd789 to 173f49a Compare September 12, 2024 11:26
@sergeyberezansky sergeyberezansky merged commit 443bd67 into dev Sep 12, 2024
11 checks passed
@sergeyberezansky sergeyberezansky deleted the sergey/docker-improvements branch September 12, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Changes to CI/CD and release workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant