-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): combine chmod with ADD in Dockerfile #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 2, 2024
Graphite Automations"Request reviewers once CI passes" took an action on this PR • (09/02/24)1 reviewer was added to this PR based on Sergey Berezansky's automation. |
sergeyberezansky
force-pushed
the
sergey/move-to-trash-error-prop
branch
from
September 3, 2024 08:45
ed86ee8
to
bc19431
Compare
sergeyberezansky
force-pushed
the
sergey/docker-improvements
branch
from
September 3, 2024 08:45
4e1cb2d
to
e48646f
Compare
This was referenced Sep 3, 2024
This was referenced Sep 11, 2024
sergeyberezansky
force-pushed
the
sergey/move-to-trash-error-prop
branch
from
September 11, 2024 10:11
bc19431
to
d119ba2
Compare
sergeyberezansky
force-pushed
the
sergey/docker-improvements
branch
from
September 11, 2024 10:11
e48646f
to
b3c8c3c
Compare
sergeyberezansky
force-pushed
the
sergey/move-to-trash-error-prop
branch
from
September 11, 2024 11:11
d119ba2
to
eb55e84
Compare
sergeyberezansky
force-pushed
the
sergey/docker-improvements
branch
from
September 11, 2024 11:11
b3c8c3c
to
1c3c1d0
Compare
sergeyberezansky
force-pushed
the
sergey/move-to-trash-error-prop
branch
from
September 11, 2024 11:34
eb55e84
to
1c8e239
Compare
sergeyberezansky
force-pushed
the
sergey/docker-improvements
branch
from
September 11, 2024 11:34
1c3c1d0
to
49081ec
Compare
sergeyberezansky
force-pushed
the
sergey/move-to-trash-error-prop
branch
from
September 11, 2024 11:51
1c8e239
to
eeb45e2
Compare
sergeyberezansky
force-pushed
the
sergey/docker-improvements
branch
from
September 11, 2024 11:51
49081ec
to
d54acf8
Compare
sergeyberezansky
force-pushed
the
sergey/move-to-trash-error-prop
branch
from
September 11, 2024 13:02
eeb45e2
to
2d3878e
Compare
sergeyberezansky
force-pushed
the
sergey/docker-improvements
branch
from
September 11, 2024 13:02
d54acf8
to
9a81bae
Compare
sergeyberezansky
force-pushed
the
sergey/move-to-trash-error-prop
branch
from
September 11, 2024 14:25
2d3878e
to
a8ef127
Compare
sergeyberezansky
force-pushed
the
sergey/docker-improvements
branch
from
September 11, 2024 14:25
9a81bae
to
f764c77
Compare
Merge activity
|
sergeyberezansky
changed the base branch from
sergey/move-to-trash-error-prop
to
graphite-base/313
September 12, 2024 11:15
sergeyberezansky
force-pushed
the
sergey/docker-improvements
branch
from
September 12, 2024 11:24
f764c77
to
bafd789
Compare
sergeyberezansky
force-pushed
the
sergey/docker-improvements
branch
from
September 12, 2024 11:26
bafd789
to
173f49a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Optimized Dockerfile for Weka CSI Driver
What changed?
FROM
statement syntax for the go-builder stagelocar
binary addition using a singleADD
command with chmodRUN chmod
command forlocar
How to test?
locar
binary, are present and executableWhy make this change?
locar
binary using a singleADD
commandchore(deps): combine chmod with ADD in Dockerfile
chore(deps): fix Dockerfile warning for FROM as