Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CSI-253): support custom CA certificate in API secret #324

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

sergeyberezansky
Copy link
Collaborator

@sergeyberezansky sergeyberezansky commented Sep 11, 2024

TL;DR

Added support for custom CA certificates in WekaFS CSI driver API client.

What changed?

  • Updated csi-wekafs-api-secret.yaml to include a new caCertificate field for HTTPS connections with self-signed or untrusted certificates.
  • Modified apiclient.go to handle custom CA certificates when creating a new API client.
  • Updated wekafs.go to parse the caCertificate from secrets and include it in the credentials.

How to test?

  1. Update the csi-wekafs-api-secret.yaml file with a base64-encoded PEM format CA certificate in the caCertificate field.
  2. Deploy the updated secret to your Kubernetes cluster.
  3. Verify that the WekaFS CSI driver can successfully connect to the Weka cluster using HTTPS with the custom CA certificate.

NOTE: for this to be tested, we still need the certificate to match endpoint names. IIRC, the certificate that is generated automatically does not have hostnames / IP address SANs.

Why make this change?

This change enhances security by allowing users to use custom CA certificates when connecting to Weka clusters, especially when using self-signed or untrusted certificates. It also prepares for the mandatory HTTPS requirement in Weka 4.3.0 and later versions.


Copy link

graphite-app bot commented Sep 11, 2024

Graphite Automations

"Request reviewers once CI passes" took an action on this PR • (09/11/24)

1 reviewer was added to this PR based on Sergey Berezansky's automation.

Copy link
Collaborator Author

sergeyberezansky commented Sep 12, 2024

Merge activity

@sergeyberezansky sergeyberezansky merged commit 9238cc3 into dev Sep 12, 2024
11 checks passed
@sergeyberezansky sergeyberezansky deleted the sergey/custom-ca-cert branch September 29, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant