-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(CSI-253): support custom CA certificate in API secret #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 11, 2024
Merged
Graphite Automations"Request reviewers once CI passes" took an action on this PR • (09/11/24)1 reviewer was added to this PR based on Sergey Berezansky's automation. |
sergeyberezansky
force-pushed
the
sergey/custom-ca-cert
branch
from
September 11, 2024 11:11
edfa630
to
35fd62f
Compare
Merge activity
|
sergeyberezansky
force-pushed
the
sergey/custom-ca-cert
branch
from
September 12, 2024 10:10
35fd62f
to
5b1968b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Added support for custom CA certificates in WekaFS CSI driver API client.
What changed?
csi-wekafs-api-secret.yaml
to include a newcaCertificate
field for HTTPS connections with self-signed or untrusted certificates.apiclient.go
to handle custom CA certificates when creating a new API client.wekafs.go
to parse thecaCertificate
from secrets and include it in the credentials.How to test?
csi-wekafs-api-secret.yaml
file with a base64-encoded PEM format CA certificate in thecaCertificate
field.Why make this change?
This change enhances security by allowing users to use custom CA certificates when connecting to Weka clusters, especially when using self-signed or untrusted certificates. It also prepares for the mandatory HTTPS requirement in Weka 4.3.0 and later versions.