Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CSI-292): parse NFS version 3.0 to correctly pass it to mountoption #372

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

sergeyberezansky
Copy link
Collaborator

@sergeyberezansky sergeyberezansky commented Oct 22, 2024

TL;DR

Updated NFS version string handling in the AsOption method.

What changed?

Modified the AsOption method in the NfsVersionString type to handle NFS version 3 mount.

How to test

Set up the chart with "3.0" as NFS version and attempt volume creation

Why make this change?

This change ensures that if due to a mistake the user specified a protocol version of NFS as 3.0 (rather than just 3), the plug in will correctly pass it to mount option string

Copy link

graphite-app bot commented Oct 22, 2024

Graphite Automations

"Request reviewers once CI passes" took an action on this PR • (10/22/24)

1 reviewer was added to this PR based on Sergey Berezansky's automation.

Copy link
Collaborator Author

sergeyberezansky commented Oct 23, 2024

Merge activity

  • Oct 23, 9:36 AM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Oct 23, 9:41 AM EDT: Graphite rebased this pull request as part of a merge.
  • Oct 23, 9:43 AM EDT: Graphite rebased this pull request as part of a merge.
  • Oct 23, 9:44 AM EDT: A user merged this pull request with Graphite.

@sergeyberezansky sergeyberezansky changed the base branch from sergey/credentials-partially-hashed-fix to graphite-base/372 October 23, 2024 13:37
@sergeyberezansky sergeyberezansky changed the base branch from graphite-base/372 to dev October 23, 2024 13:39
@sergeyberezansky sergeyberezansky merged commit 7f3494a into dev Oct 23, 2024
4 checks passed
@sergeyberezansky sergeyberezansky deleted the sergey/fix-vers3.0-parsing branch October 29, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant