fix(CSI-297): nfsTargetIps override is handled incorreclty when empty #374
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Improved handling of empty NFS target IPs in WekaFS driver.
What changed?
GetNfsMountIp
function to check if the first NFS target IP is empty before using it.fromSecrets
function to handle cases wherenfsTargetIpsRaw
is an empty string.How to test?
Why make this change?
This change prevents potential issues when empty NFS target IPs are provided in secret. It ensures that the driver doesn't attempt to use an empty IP address, which could lead to mounting failures or unexpected behavior. This improvement enhances the robustness of the WekaFS driver when dealing with various configuration scenarios.