Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CSI-297): nfsTargetIps override is handled incorreclty when empty #374

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

sergeyberezansky
Copy link
Collaborator

@sergeyberezansky sergeyberezansky commented Oct 23, 2024

TL;DR

Improved handling of empty NFS target IPs in WekaFS driver.

What changed?

  • Modified GetNfsMountIp function to check if the first NFS target IP is empty before using it.
  • Updated fromSecrets function to handle cases where nfsTargetIpsRaw is an empty string.

How to test?

  1. Configure the WekaFS driver with empty NFS target IPs.
  2. Attempt to mount a volume and verify that the driver handles the empty IP scenario gracefully.
  3. Test with valid NFS target IPs to ensure existing functionality is not affected.

Why make this change?

This change prevents potential issues when empty NFS target IPs are provided in secret. It ensures that the driver doesn't attempt to use an empty IP address, which could lead to mounting failures or unexpected behavior. This improvement enhances the robustness of the WekaFS driver when dealing with various configuration scenarios.

Copy link

graphite-app bot commented Oct 23, 2024

Graphite Automations

"Request reviewers once CI passes" took an action on this PR • (10/23/24)

1 reviewer was added to this PR based on Sergey Berezansky's automation.

Copy link
Collaborator Author

sergeyberezansky commented Oct 23, 2024

Merge activity

  • Oct 23, 9:36 AM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Oct 23, 9:46 AM EDT: Graphite rebased this pull request as part of a merge.
  • Oct 23, 9:48 AM EDT: Graphite rebased this pull request as part of a merge.
  • Oct 23, 9:49 AM EDT: A user merged this pull request with Graphite.

@sergeyberezansky sergeyberezansky changed the base branch from sergey/fix-vers3.0-parsing to graphite-base/374 October 23, 2024 13:40
@sergeyberezansky sergeyberezansky changed the base branch from graphite-base/374 to dev October 23, 2024 13:44
@sergeyberezansky sergeyberezansky merged commit a691c37 into dev Oct 23, 2024
5 checks passed
@sergeyberezansky sergeyberezansky deleted the sergey/fix-nfstargetips-override branch October 29, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant