Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revive TH tests #159

Merged
merged 1 commit into from
Sep 14, 2024
Merged

Revive TH tests #159

merged 1 commit into from
Sep 14, 2024

Conversation

phadej
Copy link
Collaborator

@phadej phadej commented Sep 9, 2024

See recent issues

@phadej phadej marked this pull request as draft September 9, 2024 10:42
@phadej phadej mentioned this pull request Sep 9, 2024
@phadej
Copy link
Collaborator Author

phadej commented Sep 9, 2024

Looks like TH.ppr has been slightly changed across GHC versions. Unfortunate, will test with latest GHC for now.

@edsko
Copy link
Collaborator

edsko commented Sep 10, 2024

The tests pass again after #162.

@phadej
Copy link
Collaborator Author

phadej commented Sep 10, 2024

Example of new diff

image

@phadej phadej marked this pull request as ready for review September 10, 2024 15:22
- Add a custom Diff implementation as I couldn't find similar already
  done
@edsko
Copy link
Collaborator

edsko commented Sep 14, 2024

Looks pretty, I like it :)

@edsko edsko merged commit ad3a28b into main Sep 14, 2024
7 checks passed
@edsko edsko deleted the revive-th-tests branch September 14, 2024 06:31
@edsko edsko mentioned this pull request Sep 14, 2024
@TravisCardwell TravisCardwell mentioned this pull request Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants