Trigger Redraw of External Widget no more working in master branch

[kdschmidt1]

Trigger Redraw of External Widget results in "react-dom.development.js:4312 Uncaught TypeError: setUpdateCount is not a function"

avnav/viewer/components/ExternalWidget.jsx

Line 65 in 9fa9b5c

triggerRedraw: () => {

[quantenschaum]

Maybe 3422450 seems to break it again or something else is broken.

Map overlay widgets get only drawn once but are not updated.

Does the widget code need to be updated?

[quantenschaum]

git bisect yields that 5934c79 is the breaking change.

[wellenvogel]

Can you describe a bit more in detail what went wrong? Is triggerRedraw not working? Or is there no redraw on a store item change?

[quantenschaum]

Uhm? It was working before 5934c79. The SailInstrument chart overlay is only drawn once and then it does not get updated. If the widget is in the widget areas it works fine, only the chart overlay does not update.

renderCanvas is called regularly, but it does not update on the screen.

There are no error messages in the JS console.

[wellenvogel]

I cannot reproduce your problem. I have a simple test widget that draws a rotating cross and that is working without any problems.
To support you I would need some code that I can use for testing.

[quantenschaum]

Interesting. You can try the https://github.com/quantenschaum/Sail_Instrument plugin. Add it as a map overlay. The widget is updated, but the overlay is not.

[quantenschaum]

@kdschmidt1 do you have this problem, too?

[quantenschaum]

Maybe something went wrong during merging on my side, I'll check that. - No, has nothing to do with merging.

[kdschmidt1]

I can confirm the error with the actual avnav master-branch and the original sailinstrument-plugin https://github.com/kdschmidt1/Sail_Instrument/releases/tag/20240731.
retesting with the latest avnav release branch https://github.com/wellenvogel/avnav/tree/release-20240616 is running properly

[quantenschaum]

5934c79 causes the problem, but I do not understand why.

[wellenvogel]

I tested with your proposed SI release and the SailInstrumentOverlay. But this draws nothing except the compass ring as it has no HDT available (although headingTrue is there). At the end there is no sail_instrument data at all - but the log gets filled with errors:
user-Sail_Instrument-ERROR-user-Sail_Instrument:setting invalid path gps.sail_instrument.HDT
So I don't think that there is any issue at the widget side.

[wellenvogel]

Ok, seems to be a problem on my test setup with multiple instances...

[wellenvogel]

Ok, after correcting my test setup I can reproduce the problem. Sometimes react18 has some strange effects...

[quantenschaum]

It's working again!