Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter Control overwrites "search" parameter in API call #2776

Closed
Bakke opened this issue Nov 22, 2016 · 2 comments · Fixed by #4311 or #4400
Closed

Filter Control overwrites "search" parameter in API call #2776

Bakke opened this issue Nov 22, 2016 · 2 comments · Fixed by #4311 or #4400
Assignees
@UtechtDustin
Labels
filter-control Issues for the filter-control extension. has PR Issues that has been fixed with a PR.

Comments

@Bakke
Copy link
Contributor

Bakke commented Nov 22, 2016

With both "search" and Filter Control enabled, Filter Control will overwrite the "search" parameter sent to server/API.

Enable search and filterControl
Search for something (not using Filter Control)
Search for something using Filter Control

The last search will now populate both "filter" and "search" parameter sent to API/server. The original search is lost (but still populating the search input field).
@Bakke Bakke mentioned this issue Nov 22, 2016
Closed
@diemus
Copy link
Contributor

diemus commented Apr 7, 2018

Sadly,it still a problem in the newest version

@mriddle mriddle mentioned this issue Nov 28, 2018
Closed
@wenzhixin wenzhixin added the filter-control Issues for the filter-control extension. label Apr 4, 2019
@UtechtDustin UtechtDustin mentioned this issue Apr 4, 2019
Closed
@UtechtDustin UtechtDustin mentioned this issue Apr 22, 2019
Merged
@ghost ghost assigned UtechtDustin Apr 22, 2019
@ghost ghost added the In progress PRs that are working in progress. label Apr 22, 2019
@UtechtDustin UtechtDustin added has PR Issues that has been fixed with a PR. and removed In progress PRs that are working in progress. labels Apr 22, 2019
@UtechtDustin UtechtDustin mentioned this issue Jun 9, 2019
Merged
@UtechtDustin UtechtDustin mentioned this issue Oct 13, 2019
Merged
@wenzhixin
Copy link
Owner

Fixed in #4624

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@UtechtDustin UtechtDustin

Labels
filter-control Issues for the filter-control extension. has PR Issues that has been fixed with a PR.
Projects
None yet
Milestone
No milestone
4 participants
@Bakke @wenzhixin @diemus @UtechtDustin