Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed triggerSearch cannot work bug #4624

Merged
merged 3 commits into from
Oct 15, 2019
Merged

Conversation

@wenzhixin wenzhixin self-assigned this Oct 6, 2019
@wenzhixin wenzhixin added the filter-control Issues for the filter-control extension. label Oct 6, 2019
@UtechtDustin
Copy link
Collaborator

Im sure we had a issue which removed the currentTarget, because of a other issue...
I will try to search the issue/PR tomorrow!

@UtechtDustin
Copy link
Collaborator

I cant find the issue..

@wenzhixin
Copy link
Owner Author

So, can we merge?

@UtechtDustin
Copy link
Collaborator

I mean we had an issue which is realted to the eventTarget, but i cant find it.
We can merge it, but it is possible that someone will reopen/comment on the old issue.

@wenzhixin
Copy link
Owner Author

#4400 ?

@UtechtDustin
Copy link
Collaborator

yes you found it ! :D
Could you check if the issue #2776, exists with your fix ?

@wenzhixin
Copy link
Owner Author

@UtechtDustin UtechtDustin merged commit 48afb78 into develop Oct 15, 2019
@UtechtDustin UtechtDustin deleted the fix/trigger-search branch October 15, 2019 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filter-control Issues for the filter-control extension.
Projects
None yet
2 participants