Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Filter Control overwrite "search" paramater #2777

Closed
wants to merge 1 commit into from
Closed

Fix Filter Control overwrite "search" paramater #2777

wants to merge 1 commit into from

Conversation

Bakke
Copy link
Contributor

@Bakke Bakke commented Nov 22, 2016

Fixes #2776

@wenzhixin wenzhixin added the filter-control Issues for the filter-control extension. label Feb 24, 2017
@djhvscf
Copy link
Collaborator

djhvscf commented Feb 24, 2017

@Bakke do you have any fiddle where we can see the issue and the solution?, thanks.

@djhvscf djhvscf added the needs example Need an example in order to confirm the issue or the PR. label Feb 24, 2017
@Bakke
Copy link
Contributor Author

Bakke commented Feb 27, 2017

https://jsfiddle.net/p63sfsvd/6/

If you search using the "search"-field you get a request like: https://swapi.co/api/people/?search=luke&order=asc&offset=0&limit=10. The "search" parameter is now "luke".

If you then filter a column you get a new request like: https://swapi.co/api/people/?search=female&order=asc&offset=0&limit=10&filter=%7B%22gender%22%3A%22female%22%7D. The "search" parameter is now "female" (the same as filter) - the original value is lost.

@Bakke
Copy link
Contributor Author

Bakke commented Feb 27, 2017

Working example: https://jsfiddle.net/qbkn7991/10/

If you search for "luke", then filter "Gender"-column to "male" the request will be: https://swapi.co/api/people/?search=luke&order=asc&offset=0&limit=10&filter=%7B%22gender%22%3A%22male%22%7D

@wenzhixin
Copy link
Owner

@djhvscf help to review this please.

@DustinUtecht
Copy link
Contributor

@djhvscf any update here ?

@diemus
Copy link
Contributor

diemus commented Apr 7, 2018

thanks for the solution@Bakke ,I have the same problem,it seems the newest code didn't sovle this problem,

@ghost
Copy link

ghost commented Jun 29, 2018

Thanks for the solution, I have the problem too
As diemus said, the fix is not in the last version, can you resolve conflicts and create a new version?
Thank you in advance

@djhvscf
Copy link
Collaborator

djhvscf commented Sep 14, 2018

Hi! We don't have any reply in that case we are going to close this PR. If you want, please create a new PR with this change against develop.

@djhvscf djhvscf closed this Sep 14, 2018
@djhvscf djhvscf added the conflict PRs that are conflicted with base branch. label Sep 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conflict PRs that are conflicted with base branch. filter-control Issues for the filter-control extension. needs example Need an example in order to confirm the issue or the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants