Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 2.7 warning about PublicSuffix::List.default #167

Closed
BrianHawley opened this issue Jan 3, 2020 · 7 comments · Fixed by #168
Closed

Ruby 2.7 warning about PublicSuffix::List.default #167

BrianHawley opened this issue Jan 3, 2020 · 7 comments · Fixed by #168
Assignees

Comments

@BrianHawley
Copy link
Contributor

Seen in testing:

.../publicsuffix-ruby/lib/public_suffix/list.rb:51: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
.../publicsuffix-ruby/lib/public_suffix/list.rb:69: warning: The called method `parse' is defined here
BrianHawley added a commit to BrianHawley/publicsuffix-ruby that referenced this issue Jan 3, 2020
@weppos weppos self-assigned this Jan 4, 2020
BrianHawley added a commit to BrianHawley/publicsuffix-ruby that referenced this issue Jan 4, 2020
@koic
Copy link

koic commented Jan 5, 2020

FYI, Ruby 2.8.0-dev does not perform deprecation warnings and implicit conversions.
ruby/ruby#2794

With this change, the following error occurs in Ruby 2.8.0-dev.

% ruby -v
ruby 2.8.0dev (2020-01-05T05:35:14Z master 54fd50c951) [x86_64-darwin17]
% bundle exec rake
(snip)

Error:
AcceptanceTest#test_ignore_private:
ArgumentError: wrong number of arguments (given 2, expected 1)
    /Users/koic/src/github.com/weppos/publicsuffix-ruby/lib/public_suffix/list.rb:69:in `parse'
    /Users/koic/src/github.com/weppos/publicsuffix-ruby/lib/public_suffix/list.rb:51:in `default'
    /Users/koic/src/github.com/weppos/publicsuffix-ruby/lib/public_suffix.rb:69:in `parse'
    /Users/koic/src/github.com/weppos/publicsuffix-ruby/lib/public_suffix.rb:143:in `domain'
    /Users/koic/src/github.com/weppos/publicsuffix-ruby/test/acceptance_test.rb:105:in `block in test_ignore_private'
    /Users/koic/src/github.com/weppos/publicsuffix-ruby/test/acceptance_test.rb:101:in `each'
    /Users/koic/src/github.com/weppos/publicsuffix-ruby/test/acceptance_test.rb:101:in `test_ignore_private'

I look forward to this patch release of public_suffix gem because that resolves the error of Ruby 2.8.0-dev CI matrix in dependent gems.

@weppos
Copy link
Owner

weppos commented Jan 5, 2020

@koic are you able to confirm that #168 will solve your issue in Ruby 2.8.0-dev?

@weppos
Copy link
Owner

weppos commented Jan 5, 2020

Actually, I believe I can confirm it does given the CI run completed.

weppos pushed a commit that referenced this issue Jan 5, 2020
weppos added a commit that referenced this issue Jan 5, 2020
@weppos
Copy link
Owner

weppos commented Jan 5, 2020

4.0.3 packaged and released. Thanks.

@koic
Copy link

koic commented Jan 5, 2020

Thanks for your prompt reply! Yeah, #168 solved my issue in Ruby 2.8.0-dev.
BTW, rubygems.org doesn't seem to have released 4.0.3 yet. Could you please confirm at your convenience?
https://rubygems.org/gems/public_suffix

@weppos
Copy link
Owner

weppos commented Jan 5, 2020

It should be released now.

@koic
Copy link

koic commented Jan 5, 2020

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants