Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecations and warnings #168

Merged
merged 1 commit into from
Jan 5, 2020
Merged

Fix deprecations and warnings #168

merged 1 commit into from
Jan 5, 2020

Conversation

BrianHawley
Copy link
Contributor

[Fixes #167]

@codecov-io
Copy link

codecov-io commented Jan 3, 2020 •
edited
Loading

Codecov Report

Merging #168 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #168   +/-   ##
=======================================
  Coverage   99.83%   99.83%           
=======================================
  Files          11       11           
  Lines         619      619           
=======================================
  Hits          618      618           
  Misses          1        1
Impacted Files Coverage Δ
lib/public_suffix/list.rb 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec6bc1d...1446307. Read the comment docs.

@weppos weppos self-assigned this Jan 4, 2020
weppos
weppos requested changes Jan 4, 2020
View reviewed changes
Copy link
Owner

@weppos weppos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patch @BrianHawley! I left a couple of comments inline.

test/test_helper.rb
@@ -10,7 +10,7 @@

require "minitest/autorun"
require "minitest/reporters"
require "mocha/setup"
require "mocha/minitest"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change directly related to the warning issues?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's related to a separate warning that came up while I was running the test suite locally. The mocha gem tells you that "mocha/setup" is deprecated, and that you should require one of the more specific setups. This is the appropriate one for your test suite.

.gitignore Outdated Show resolved Hide resolved
@weppos weppos mentioned this pull request Jan 5, 2020
Closed
@weppos weppos merged commit bac3a1d into weppos:master Jan 5, 2020
weppos added a commit that referenced this pull request Jan 5, 2020
@weppos
CHANGELOG for GH-167
41f54ea 
See GH-167, GH-168
Thanks @BrianHawley
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weppos weppos weppos requested changes

Assignees

@weppos weppos

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ruby 2.7 warning about PublicSuffix::List.default
3 participants
@BrianHawley @codecov-io @weppos