feat(http): onFetchRequest #2048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 6dbe040 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tmm
force-pushed
the
tmm/on-fetch-request
branch
from
b8871cc to
b8fe3e4
Compare
tmm
commented
Mar 30, 2024
| fetchOptions?: Omit<RequestInit, 'body'> | undefined | ||
| // A callback to handle the response. | ||
| /** A callback to handle the request. */ | ||
| onRequest?: ((request: Request) => Promise<void> | void) | undefined |
There was a problem hiding this comment.
Might be more useful to type with input and init instead.
(input: string | Request | URL, init?: RequestInit | undefined) => Promise<void> | void
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2048 +/- ##
==========================================
- Coverage 92.65% 92.65% -0.01%
==========================================
Files 568 568
Lines 49472 49479 +7
Branches 1900 1899 -1
==========================================
+ Hits 45840 45845 +5
- Misses 3589 3591 +2
Partials 43 43 ☔ View full report in Codecov by Sentry. |
Merged
This was referenced May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR enhances the
httptransport inviemby adding anonFetchRequestcallback.Detailed summary
onFetchRequestcallback tohttptransport for handling fetch requests.httpfunction to includeonFetchRequestandonFetchResponseoptions.HttpRpcClientOptionswithonRequestandonResponsecallbacks.onFetchRequestandonRequesthandling in various test cases.getHttpRpcClientfunction to utilizeonRequestcallback for request handling.