If already connected it shows another prompt for selecting account

[mqklin]

Describe the bug

connect shouldn't show prompt for selecting account if already connected. In MetaMask it makes 2 extra popups every time user log in a dApp, this makes UX confusing.

Glitch helped to find this: https://github.com/wevm/wagmi/blob/main/packages/core/src/connectors/injected.ts#L154C38-L154C87

Link to Minimal Reproducible Example

No response

Steps To Reproduce

https://lab.web3modal.com/library/wagmi/

1. Click "Connect wallet", connect some acc
2. Click "Disconnect"
3. Make sure acc is still connected to the site
4. Click "Connect wallet" again

Please check the video:
https://github.com/wevm/wagmi/assets/9456433/f80a2631-91ea-4be9-ab48-ce4c08b0456e

Wagmi Version

@wagmi/core 2.6.5, wagmi/connectors 4.1.14

Viem Version

2.7.9

TypeScript Version

I don't use TypeScript

Check existing issues

• I checked there isn't already an issue for the bug I encountered.

Anything else?

No response

[1997roylee]

I believe the issue is triggered by Metamask.

[mqklin]

Maybe, but what would u suggest? In my experience, MetaMask need at least 1 month to fix something. IMO it's a low chance they will prio this task just because of wagmi. On the other hand, wagmi introduced this UX breaking change. So I can't upgrade libs (wagmi/ viem to v2) till this is fixed.

[tmm]

This is intentional. Since MetaMask (and some other wallets do not support disconnect), Wagmi shims this behavior. When you connect after disconnecting, Wagmi attempts to show the account selector just like when you connect for the first time.

[mqklin]

@tmm Is there a way to make it work like in v1? Why shimDisconnect: false doesn't affect this behaviour?

[tmm]

Feel free to open a PR that disables this when shimDisconnect is false.

[github-actions]

This issue has been locked since it has been closed for more than 14 days.

If you found a concrete bug or regression related to it, please open a new bug report with a reproduction against the latest wagmi version. If you have any other comments you can create a new discussion.