injected.ts - check shimDisconnect before requestPermissions

[mqklin]

Following #3603

Description

shimDisconnect should be considered before showing prompt for selecting account

Additional Information

Before submitting this issue, please make sure you do the following.

• Read the contributing guide
• Added documentation related to the changes made.
• Added or updated tests (and snapshots) related to the changes made.

[changeset-bot]

🦋 Changeset detected

Latest commit: 46e33ce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@wagmi/core	Patch
@wagmi/connectors	Patch
wagmi	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
wagmi	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 27, 2024 6:49pm

[mqklin]

From my understanding there is only one-line change? Also not sure what to do with changeset..

[mqklin]

I tested it on SanR.app codebase, no bugs encountered.

[mqklin]

@tmm any chance for this to be reviewed / merged / released?

[mqklin]

I donated $200 in hope this will be prioritized https://explorer.zksync.io/tx/0xc8316292532d5636fe4086e0e9434bf7ea63b33538ce6a7890ae73cd2c39d5cb
https://explorer.zksync.io/tx/0x495e573050afd1fe07cf5b0e0ad5ecc8f745a129f6c5c19c20e16b6f205f778d

[mqklin]

So I believe the way to resolve is 1) merge this PR 2) fix the bug I described here: #3608 (comment)

IDK how to fix it. shimDisconnect is only passed to injected, but how to save it and pass further to createConfig? I see 3 ways:

1. pass shimDisconnect to createConfig, but this duplicates the code:

const wagmiConfig = createConfig({
  ...,
  shimDisconnect: false,
  connectors: [
    injected({shimDisconnect: false}),
  ],
});

2. Save shimDisconnect as a closure in injected.ts, which looks hacky:

let shimDisconnect;
export function injected(parameters = {}) {
  shimDisconnect ??= parameters.shimDisconnect ?? true;
  const { unstable_shimAsyncInject } = parameters;
  ...

To make it work "clear", shimDisconnect should be passed to midp lib, which is I believe not what you want. So seems like 2nd option I provided is the best way to fix the bug.

3. nd option is to save shimDisconnect inside createConnector config:

...
        get shimDisconnect() {
          return shimDisconnect;
        }

Then create connectors inside createConfig just to get this shimDisconnect:

...
  const shimDisconnect = rest.connectors.map(f => f()).some(connector => connector.shimDisconnect);
  ...
  ? mipd?.getProviders().map(providerDetailToConnector.bind(null, shimDisconnect)) ?? []
...

And receive it in providerDetailToConnector function below:

...
    function providerDetailToConnector(providerDetail, shimDisconnect) {
        const { info } = providerDetail;
        const provider = providerDetail.provider;
        return injected({ shimDisconnect, target: { ...info, id: info.rdns, provider } });
    }
...

[mqklin]

@jxom please let me know if you want me to PR 2nd option I provided above