Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

injected.ts - check shimDisconnect before requestPermissions #3608

Merged
merged 5 commits into from
Mar 27, 2024
Merged

injected.ts - check shimDisconnect before requestPermissions #3608

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c122815
injected.ts - check shimDisconnect before requestPermissions
mqklin Feb 16, 2024
5240d51
FIx changeset
mqklin Feb 21, 2024
4f3ef05
Update packages/core/src/connectors/injected.ts
mqklin Mar 4, 2024
19ac960
Update .changeset/two-sheep-shop.md
tmm Mar 27, 2024
46e33ce
Update .changeset/two-sheep-shop.md
tmm Mar 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/two-sheep-shop.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@wagmi/core": minor
tmm marked this conversation as resolved.
Show resolved Hide resolved
---

Add shimDisconnect check to disable MetaMask requestPermissions if it's false
tmm marked this conversation as resolved.
Show resolved Hide resolved
2 changes: 1 addition & 1 deletion packages/core/src/connectors/injected.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ export function injected(parameters: InjectedParameters = {}) {
if (!isReconnecting) {
accounts = await this.getAccounts().catch(() => null)
const isAuthorized = !!accounts?.length
if (isAuthorized)
if (isAuthorized && shimDisconnect)
// Attempt to show another prompt for selecting account if already connected
try {
const permissions = await provider.request({
Expand Down