-
-
Notifications
You must be signed in to change notification settings - Fork 827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Font rendering isn't gamma corrected when using WebGpu? #3032
Comments
I'm getting the same effect when using the WebGpu front end across several systems and GPUs both on an older version of Wezterm and the nightly version when I tested this (2023-02-02). WezTerm version Configuration Older Desktop PC - Window 10 Pro (10.0.19045)OpenGL version: OpenGL version: WebGPU: Newer Desktop PC - Windows 10 Pro (10.0.19045)OpenGL: OpenGL version: WebGPU: Laptop - Fedora Workstation 37Wayland on Mutter compositor. OpenGL version: WebGPU: Particularly noticeable with an inherently thinner font face like Iosevka. |
I think this is an upstream bug with the vulkan backend, and we're waiting on a release: |
There was a recent wgpu release that adds some explicit control over srgb-ness, so I've updated to that. |
Can confirm that I'd been banging my head against my keyboard struggling with various incantions of edit: This is on Windows 10 with a GTX 1080. |
This might help with wez#3032
Also getting overly thick/bold fonts and odd flicker on WebGpu with Wayland & Nvidia. Upgrading to wgpu 0.15.1 doesn't seem to help. diff --git a/wezterm-gui/Cargo.toml b/wezterm-gui/Cargo.toml
index 046837dc..de425b7c 100644
--- a/wezterm-gui/Cargo.toml
+++ b/wezterm-gui/Cargo.toml
@@ -101,7 +101,7 @@ wezterm-mux-server-impl = { path = "../wezterm-mux-server-impl" }
wezterm-ssh = { path = "../wezterm-ssh" }
wezterm-term = { path = "../term", features=["use_serde"] }
wezterm-toast-notification = { path = "../wezterm-toast-notification" }
-wgpu = "0.15"
+wgpu = "0.15.1"
window = { path = "../window" }
window-funcs = { path = "../lua-api-crates/window-funcs" } I've tried to video capture the flicker but it doesn't show up due to the video framerate and I can't get OBS working on wayland. The flicker seems to display a previous frame for a brief second. Like so. 1 -> 1 -> 1 -> 2 -> 2 -> 1* -> 2 -> 2 * Should be frame 2 but previous frame is drawn for a couple refresh cycles. |
I have the exact same issue on Ubuntu 22.04 running Gnome with Wayland. Using OpenGL resolves the issue. I am using the latest Nightly build.
|
Same problem running the nightly rpm version on Fedora 36, any solutions aside from using openGL as the front end? |
@xorander00 see also this issue, which may also apply to fbsd: |
@wez Confirmed, upgrading the driver fixed it. For future reference to anyone else, this worked for me...
|
Getting the same issue on M2 Pro. Decided to downgrade from most recent release. Very weird font behavior.. @wez - happy to provide more details if you have time (I don't expect) to look into this. Thanks for a great f*ing terminal! Been loving it after ~3 years on Alacritty. |
when you say "the most recent release" are you talking about the one made today, or the one from the other day? |
I'm talking about this one, which changed the default
I can provide some screenshots of the process if you interested, least I can do with the great work you've done here! |
I think that's a different issue that relates to macOS font fallback; please file a separate issue |
@wez, tested things again this morning, but issue seems to be gone since you changed the front end back to OpenGL. I still notice a little issue but not sure if worth reporting. Let me know what you think (notice the different colors in the prompt) |
Sorry, but I can't really see anything in that image: it's too big. If you want to highlight differences, please keep the screenshots focused in a small region around the area of interest so that it is much easier to see at a glance. |
What Operating System(s) are you seeing this problem on?
Windows
Which Wayland compositor or X11 Window manager(s) are you using?
No response
WezTerm version
20230124-182614-9d7e613c
Did you try the latest nightly build to see if the issue is better (or worse!) than your current version?
Yes, and I updated the version box above to show the version of the nightly that I tried
Describe the bug
Using WebGpu, font rendering appears fine when using a negative polarity (light-on-dark) color scheme. However, when using a positive polarity (dark-on-light) color scheme, fonts appear not to be properly gamma corrected, in that their opacity seems too low and so the dark text color blends too much into the light background. On the right half of the above image, I included Windows Terminal as a reference example more in line with what I would consider normal.
To Reproduce
Use a dark-on-light color scheme while using WebGpu and observe the faint text rendering.
Configuration
front_end = "WebGpu",
freetype_load_target = "Normal",
freetype_render_target = "Normal"
Expected Behavior
Light text rendered against a dark background should appear as clear and fully opaque as dark text rendered against a light background.
Logs
wezterm version: 20230124-182614-9d7e613c x86_64-pc-windows-msvc
Window Environment: Windows
OpenGL version: WebGPU: name=NVIDIA GeForce RTX 2080, device_type=DiscreteGpu, backend=Vulkan, driver=NVIDIA, driver_info=516.94, vendor=4318, device=7810
Anything else?
No response
The text was updated successfully, but these errors were encountered: