This repository has been archived by the owner on Jul 25, 2022. It is now read-only.
Disable xattr copy in rsync #2320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Evans <beevans@whamcloud.com>
utopiabound
reviewed
Oct 9, 2020
| @@ -26,7 +26,6 @@ fn do_rsync<'a>( | |||
| let output = Command::new("rsync") | |||
| .arg("-a") | |||
| .arg("-t") | |||
| .arg("-X") | |||
There was a problem hiding this comment.
Don't we WANT xattrs? otherwise we lose striping info, right?
There was a problem hiding this comment.
Right, but if you copy it to NFS the whole thing fails. We need to create an enhancement for this to duplicate them somehow on the side like other systems do, or only support them for mountpoints that support xattrs.
There was a problem hiding this comment.
okay. We should probably check at some point, but we would want to cache answer locally, so it can wait.
utopiabound
approved these changes
Oct 9, 2020
jgrund
approved these changes
Oct 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ben Evans beevans@whamcloud.com
This change is