Skip to content
This repository has been archived by the owner on Jul 25, 2022. It is now read-only.

Disable xattr copy in rsync #2320

Merged
merged 1 commit into from
Oct 9, 2020
Merged

Disable xattr copy in rsync #2320

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion iml-agent/src/action_plugins/stratagem/action_filesync.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ fn do_rsync<'a>(
let output = Command::new("rsync")
.arg("-a")
.arg("-t")
.arg("-X")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we WANT xattrs? otherwise we lose striping info, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, but if you copy it to NFS the whole thing fails. We need to create an enhancement for this to duplicate them somehow on the side like other systems do, or only support them for mountpoints that support xattrs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay. We should probably check at some point, but we would want to cache answer locally, so it can wait.

.arg(&work.src_file)
.arg(&work.dest_file)
.output()
Expand Down