Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta: Review Draft infrastructure #125

Merged
merged 3 commits into from
May 29, 2018
Merged

Meta: Review Draft infrastructure #125

merged 3 commits into from
May 29, 2018

Conversation

foolip
Copy link
Member

@foolip foolip commented May 14, 2018

See whatwg/whatwg.org#197 for details.

@annevk
Copy link
Member

annevk commented May 14, 2018

Thanks for helping out. You'll want to update the README too.

@foolip
Copy link
Member Author

foolip commented May 14, 2018

I saw the README changes in whatwg/url#387 but they seem unrelated, am I missing a connection?

@annevk
Copy link
Member

annevk commented May 14, 2018

I guess they are a bit, but it seems worthwhile grouping Meta changes together. It's basically about making the instructions a little better for new folks. Nobody should really bother with setting up Bikeshed or even building locally necessarily these days.

@foolip
Copy link
Member Author

foolip commented May 14, 2018

If that is the intent I think the remote target should be made the first one, since that's what you'll get if you just try make.

@annevk
Copy link
Member

annevk commented May 14, 2018

Yeah, that's not a bad idea and I was thinking that too, but didn't go for it for unclear reasons. @domenic?

@domenic
Copy link
Member

domenic commented May 14, 2018

Seems reasonable, as long as local is still an option.

@annevk annevk added the do not merge yet Pull request must not be merged per rationale in comment label May 29, 2018
@annevk
Copy link
Member

annevk commented May 29, 2018

I pushed a commit that aligns this with other outstanding PRs.

@annevk
Copy link
Member

annevk commented May 29, 2018

Mentioning whatwg/meta#92 for the backlink.

@domenic domenic removed the do not merge yet Pull request must not be merged per rationale in comment label May 29, 2018
@domenic domenic merged commit 6e49fbc into master May 29, 2018
@domenic domenic deleted the review-draft-prep branch May 29, 2018 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants