Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta: Review Draft infrastructure #387

Merged
merged 3 commits into from
May 29, 2018
Merged

Meta: Review Draft infrastructure #387

merged 3 commits into from
May 29, 2018

Conversation

annevk
Copy link
Member

@annevk annevk commented May 11, 2018

See whatwg/whatwg.org#197 for details.

@annevk annevk requested a review from domenic May 11, 2018 16:51
README.md Outdated

If you want to do a complete "local deploy" including commit and/or branch snapshots, run
`make deploy`.
If you want to verify your changes before submitting them to GitHub, run `make deploy`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel not great about recommending people do full make deploy with its three curlbikesheds; I'd rather continue recommending make remote as a quicker flow for local iteration.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So make remote doesn't do Bikeshed warnings and doesn't run our lint. And you can stop make deploy when you got the information about those (if you don't care about a preview).

We could mention make remote, but then we should probably mention it might not be sufficient.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, mentioning it for quick iteration, but noting that it's not sufficient, was my thought.

@annevk
Copy link
Member Author

annevk commented May 14, 2018

Okay, I think this is good now. Once we verify the other bits I'll make PRs for the other repositories.

@domenic
Copy link
Member

domenic commented May 14, 2018

I think we should add a pointer to whatwg/meta CONTRIBUTING.md that explains the build process in a bit more detail, including things like "where do I get Make on Windows" or "how can I build while I'm on an airplane" (by installing Bikeshed). I'll work on that and the corresponding whatwg/meta PR today.

@annevk
Copy link
Member Author

annevk commented May 14, 2018

@foolip remarked that we should make make remote the default, which we seem to have agreement on, as long as make local remains available.

See whatwg/whatwg.org#197 and
whatwg/meta#92 for details.

This also updates the web-platform-tests and IRC URLs.
@annevk annevk force-pushed the annevk/review-draft-prep branch from 2871d9a to 457d88b Compare May 29, 2018 10:54
@annevk annevk added the do not merge yet Pull request must not be merged per rationale in comment label May 29, 2018
@domenic domenic removed the do not merge yet Pull request must not be merged per rationale in comment label May 29, 2018
@domenic domenic merged commit 5e58d1d into master May 29, 2018
@domenic domenic deleted the annevk/review-draft-prep branch May 29, 2018 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants