-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meta: Review Draft infrastructure #387
Conversation
README.md
Outdated
|
||
If you want to do a complete "local deploy" including commit and/or branch snapshots, run | ||
`make deploy`. | ||
If you want to verify your changes before submitting them to GitHub, run `make deploy`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel not great about recommending people do full make deploy
with its three curlbikesheds; I'd rather continue recommending make remote
as a quicker flow for local iteration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So make remote doesn't do Bikeshed warnings and doesn't run our lint. And you can stop make deploy when you got the information about those (if you don't care about a preview).
We could mention make remote, but then we should probably mention it might not be sufficient.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, mentioning it for quick iteration, but noting that it's not sufficient, was my thought.
Okay, I think this is good now. Once we verify the other bits I'll make PRs for the other repositories. |
I think we should add a pointer to whatwg/meta CONTRIBUTING.md that explains the build process in a bit more detail, including things like "where do I get Make on Windows" or "how can I build while I'm on an airplane" (by installing Bikeshed). I'll work on that and the corresponding whatwg/meta PR today. |
@foolip remarked that we should make |
See whatwg/whatwg.org#197 and whatwg/meta#92 for details. This also updates the web-platform-tests and IRC URLs.
2871d9a
to
457d88b
Compare
See whatwg/whatwg.org#197 for details.